Skip to content

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 26, 2025
Merged

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #356

merged 9 commits into from
Nov 26, 2025

Conversation

@mounicatellabati
Copy link
Contributor

@mounicatellabati mounicatellabati commented Nov 21, 2025 •
edited
Loading

Description

Added clarification to the cloud_monitoring_instance_crn variable description in both the module and DA to state that once the Monitoring Instance CRN is connected to the Security and Compliance Center Workload Protection service, it cannot be modified or updated. for issue https://github.ibm.com/GoldenEye/issues/issues/16321.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@mounicatellabati
Copy link
Contributor Author

mounicatellabati commented Nov 21, 2025

/run pipeline

@jor2
Copy link
Member

jor2 commented Nov 24, 2025

Update to latest submodule git submodule update --remote --merge after you do a git submodule --init.

@mounicatellabati
Copy link
Contributor Author

mounicatellabati commented Nov 26, 2025

/run pipeline

@mounicatellabati mounicatellabati marked this pull request as draft November 26, 2025 06:53
@mounicatellabati
Copy link
Contributor Author

mounicatellabati commented Nov 26, 2025

/run pipeline

@mounicatellabati mounicatellabati marked this pull request as ready for review November 26, 2025 09:46
ocofaigh
ocofaigh requested changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@mounicatellabati
fix: Update description for existing_monitoring_crn variable
502dde6 
Removed the external link from the description of the existing_monitoring_crn variable.
@mounicatellabati
Copy link
Contributor Author

mounicatellabati commented Nov 26, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 4918591 into main Nov 26, 2025
2 checks passed
@ocofaigh ocofaigh deleted the update-connected_instance branch November 26, 2025 14:11
@ocofaigh ocofaigh mentioned this pull request Nov 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@akocbek akocbek Awaiting requested review from akocbek akocbek is a code owner

@jor2 jor2 Awaiting requested review from jor2 jor2 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mounicatellabati @jor2 @ocofaigh