Skip to content

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 26, 2025
Merged

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d8bcdc
refactor: updating the lifecycle block to ignore cloud_monitoring_con…
Nov 21, 2025
8050184
Fix: CSPM variable description punctuation
mounicatellabati Nov 21, 2025
a14ef05
fix: added a code comment
mounicatellabati Nov 21, 2025
e25a4bc
Fix: description punctuation in variables.tf
mounicatellabati Nov 21, 2025
8dd3ffc
fix: Remove comment from lifecycle ignore_changes
mounicatellabati Nov 21, 2025
7be22d8
Merge branch 'main' into update-connected_instance
mounicatellabati Nov 26, 2025
ba70822
fix: "fixed"
mounicatellabati Nov 26, 2025
cb181e3
fix: indentation issues
Nov 26, 2025
502dde6
fix: Update description for existing_monitoring_crn variable
mounicatellabati Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ resource "ibm_resource_instance" "scc_wp" {
parameters = {
cloud_monitoring_connected_instance = var.cloud_monitoring_instance_crn
}
# lifecycle ignores cloud_monitoring_conmected_instance as it can't change after scc-workload-protection instance connects.
lifecycle {
ignore_changes = [
parameters["cloud_monitoring_connected_instance"]
Expand Down
2 changes: 1 addition & 1 deletion solutions/fully-configurable/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ variable "existing_monitoring_crn" {
type = string
nullable = true
default = null
description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create the connection. Once the connection is created, the Monitoring instance CRN cannot be changed. Learn more](https://www.ibm.com/products/cloud-monitoring)"
description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create the connection. Once the connection is created, the Monitoring instance CRN cannot be changed."

validation {
condition = anytrue([
Expand Down