Skip to content

Conversation

@mukulpalit-ibm
Copy link
Contributor

@mukulpalit-ibm mukulpalit-ibm commented Sep 16, 2025

Description

Update default value for endpoint type

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@mukulpalit-ibm mukulpalit-ibm changed the title Update endpoint typw Update endpoint type Sep 16, 2025
@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint_type should be hidden in the ibm_catalog.json ("hidden": true)

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm
Copy link
Contributor Author

endpoint_type should be hidden in the ibm_catalog.json ("hidden": true)

It was not implemented to keep it in consistent with private/public cert engine catalog json. Changed now

@ocofaigh ocofaigh merged commit 2e49912 into main Sep 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the fix-endpoint-type branch September 16, 2025 14:30
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants