feat : 13662 custom engine #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukulpalit-ibm
requested review from
daniel-butler-irl and
ocofaigh
as code owners
mukulpalit-ibm
changed the title
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
shemau
reviewed
Aug 20, 2025
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
shemau
requested changes
Aug 29, 2025
ocofaigh
previously requested changes
Aug 29, 2025
|
/run pipeline |
|
/run pipeline |
shemau
previously approved these changes
Sep 3, 2025
ocofaigh
requested changes
Sep 3, 2025
| ############################################################################## | ||
|
|
||
| resource "ibm_iam_authorization_policy" "sm_ce_policy" { | ||
| source_service_name = "secrets-manager" |
There was a problem hiding this comment.
As with all auth policies, there should be a count used here with a boolean to skip it if user wants.
There was a problem hiding this comment.
added var.skip_secrets_manager_iam_auth_policy ? flag to catalog, main module and DA
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
reviewed
Sep 3, 2025
ocofaigh
reviewed
Sep 3, 2025
|
/run pipeline |
ocofaigh
approved these changes
Sep 3, 2025
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers