Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Oct 31, 2025

Description

#376

Note: common-dev-assets is matched with the latest main, which is ahead of the renovate/dependencies branch. So it is expected that it does not show in this branch.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from alex-reiff as a code owner October 31, 2025 15:14
@shemau
Copy link
Contributor Author

shemau commented Oct 31, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Oct 31, 2025

The following error is seen in the upgrade test:

 TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: Terraform used the selected providers to generate the following execution
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: plan. Resource actions are indicated with the following symbols:
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:   ~ update in-place
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: 
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: Terraform will perform the following actions:
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: 
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:   # module.secrets_manager.ibm_iam_authorization_policy.iam_identity_policy[0] will be updated in-place
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:   ~ resource "ibm_iam_authorization_policy" "iam_identity_policy" {
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:       ~ description                 = "Allows Secrets Manager instance 12a1a780-8450-4b9f-92d5-832cf848e960 `Operator` access to the IAM Identity service to enable creating IAM credentials." -> "Allows Secrets Manager instance 12a1a780-8450-4b9f-92d5-832cf848e960 access to the IAM Identity service to enable creating IAM credentials."
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:         id                          = "4263863e-8613-4e83-8822-14206d1a653b"
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:       ~ roles                       = [
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:             "Operator",
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:           + "User API key creator",
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:           + "Service ID creator",
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:         ]
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:         # (10 unchanged attributes hidden)
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: 
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:         # (2 unchanged blocks hidden)
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212:     }
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: 
TestRunUpgradeExample 2025-10-31T15:33:44Z command.go:212: Plan: 0 to add, 1 to change, 0 to destroy.

This is in a submodule in the test and not in the main module, so it can safely be skipped.

@shemau
Copy link
Contributor Author

shemau commented Oct 31, 2025

/run pipeline

@akocbek akocbek merged commit 7a35c15 into main Oct 31, 2025
2 checks passed
@akocbek akocbek deleted the depend branch October 31, 2025 17:38
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants