Skip to content

Conversation

@Aayush-Abhyarthi
Copy link
Member

Description

https://github.ibm.com/GoldenEye/issues/issues/13201

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Includes fix for catalog onboarding failure

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Contributor

@Aayush-Abhyarthi Please confirm you did an end to end test (imported to catalog, confirmed addons worked etc)

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi Aayush-Abhyarthi requested a review from Ak-sky June 24, 2025 10:02
@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Co-authored-by: Conall Ó Cofaigh <[email protected]>
@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused - why is internet_services_crn required in the DA but not the module? cc @alex-reiff

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit f800a0f into main Jun 25, 2025
2 checks passed
@ocofaigh ocofaigh deleted the onboarding-failure branch June 25, 2025 16:58
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants