DA improvements #246
Merged
DA improvements #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
mukulpalit-ibm
requested changes
Jul 22, 2025
|
/run pipeline |
|
/run pipeline |
mukulpalit-ibm
requested changes
Jul 29, 2025
mukulpalit-ibm
requested changes
Jul 29, 2025
Co-authored-by: Mukul Palit <[email protected]>
Co-authored-by: Mukul Palit <[email protected]>
Co-authored-by: Mukul Palit <[email protected]>
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
The certificate engines don't have their own symbols as such. While creating the DA we decided to use the same secret manager symbol for engine as well. cc: @ocofaigh |
|
For showing multiple engine in diagram, I don't think with this DA we can create multiple engine via DA. |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
maheshwarishikha
previously approved these changes
Sep 30, 2025
|
/run pipeline |
|
/run pipeline |
ocofaigh
reviewed
Sep 30, 2025
|
/run pipeline |
maheshwarishikha
approved these changes
Sep 30, 2025
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.ibm.com/GoldenEye/issues/issues/14313
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR Updates the catalog json for improved DA User experience as well as updates the IAM permissions needed to successfully deploy the DA with add ons
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers