generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 0
DA improvements #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DA improvements #246
Changes from 7 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
d8ea80e
DA improvements
Aayush-Abhyarthi 5ed9f4a
add: index
Aayush-Abhyarthi e72ee13
Merge branch 'main' into improve-DA
Aayush-Abhyarthi d0de98e
add: permissions
Aayush-Abhyarthi 3691571
Merge remote-tracking branch 'origin/improve-DA' into improve-DA
Aayush-Abhyarthi 2586f3b
resolve conflicts
Aayush-Abhyarthi 1f0e999
revert
Aayush-Abhyarthi 48e4812
resolve comments
Aayush-Abhyarthi 6aa57ec
Merge branch 'main' into improve-DA
Aayush-Abhyarthi c50c333
resolve conflicts
Aayush-Abhyarthi ee542d4
Merge branch 'main' into improve-DA
Aayush-Abhyarthi ea00a80
Update ibm_catalog.json
Aayush-Abhyarthi 00d76ca
Update ibm_catalog.json
Aayush-Abhyarthi 51f2158
Update ibm_catalog.json
Aayush-Abhyarthi c2a216c
resolve comments
Aayush-Abhyarthi 2810162
Merge branch 'main' into improve-DA
Aayush-Abhyarthi 36d8a65
resolve comments
Aayush-Abhyarthi 9410b44
Merge branch 'main' into improve-DA
Aayush-Abhyarthi 405de98
fix: diagram
Aayush-Abhyarthi fdabc65
more fixes
Aayush-Abhyarthi 1efbc11
Update ibm_catalog.json
Aayush-Abhyarthi 95209e3
Update ibm_catalog.json
Aayush-Abhyarthi 67ca1ce
Update ibm_catalog.json
Aayush-Abhyarthi f7ddd2a
Update ibm_catalog.json
Aayush-Abhyarthi 32d5403
Update ibm_catalog.json
Aayush-Abhyarthi 6e51e85
Update ibm_catalog.json
Aayush-Abhyarthi 3b2ae3c
Update ibm_catalog.json
Aayush-Abhyarthi 9c63070
Update ibm_catalog.json
Aayush-Abhyarthi 7ffcaa7
Update ibm_catalog.json
Aayush-Abhyarthi f18ef1e
resolve comments
Aayush-Abhyarthi 149d759
Merge branch 'main' into improve-DA
Aayush-Abhyarthi a7b043f
Update ibm_catalog.json
Aayush-Abhyarthi ad6dd9c
Update ibm_catalog.json
Aayush-Abhyarthi 974216e
fix: capitalization
Aayush-Abhyarthi b46e672
fix: diagram
Aayush-Abhyarthi 27a3f3b
Merge branch 'main' into improve-DA
Aayush-Abhyarthi 68610bc
Update solutions/fully-configurable/README.md
Aayush-Abhyarthi bd173d4
resolve comments
Aayush-Abhyarthi d47ecd4
pass cis
Aayush-Abhyarthi 91700c7
revert prefix
Aayush-Abhyarthi cf5ec43
revert prefix
Aayush-Abhyarthi 5270ce0
Update ibm_catalog.json
Aayush-Abhyarthi 4bdbef7
Merge branch 'main' into improve-DA
Aayush-Abhyarthi 5ef5e88
resolve comments
Aayush-Abhyarthi 466776f
update diagram
Aayush-Abhyarthi 9c16099
update: diagram
Aayush-Abhyarthi 565d589
Merge branch 'main' into improve-DA
Aayush-Abhyarthi 95894de
Merge branch 'main' into improve-DA
Aayush-Abhyarthi 6f3deec
fix: split observability related updates
Aayush-Abhyarthi 145b7b8
fixes
Aayush-Abhyarthi 5053157
update content
68404e5
update cert name
Aayush-Abhyarthi c8b3ee0
Merge remote-tracking branch 'origin/improve-DA' into improve-DA
Aayush-Abhyarthi 6af423f
resolve comment
Aayush-Abhyarthi bc69586
remove cda
Aayush-Abhyarthi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Submodule common-dev-assets
updated
6 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,3 @@ | ||
| # Secrets Manager Public Certificate Engine | ||
| # Cloud automation for Secrets Manager Public Certificate Engine (Fully configurable) | ||
Aayush-Abhyarthi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| This solution supports the following: | ||
| - Provisioning a Secrets Manager public certificate authority configuration to configure Let's Encrypt as a Certificate Authority (CA). | ||
| - Provisioning a Secrets Manager DNS provider configuration for IBM Cloud Internet Services. | ||
| - Provisioning a Secrets Manager to Cloud Internet Service authorization policy. | ||
|
|
||
|  | ||
|
|
||
| **NB:** This solution is not intended to be invoked by other modules, as it includes provider configuration. As a result, it is incompatible with the `for_each`, `count`, and `depends_on` arguments. For more information see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers) | ||
| :exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information, see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.