Skip to content

Conversation

@mukulpalit-ibm
Copy link
Contributor

@mukulpalit-ibm mukulpalit-ibm commented Dec 1, 2025

Description

This PR removes the inappropriate usage of service_endpoints variable and replaces it with endpoint_type variable to define how to communicate with SM for public-cert module call.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

The service_endpoints variable is replaced with endpoint_type. This defines the secrets manager endpoint type for the terraform provider to target when creating the private certificate.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

1 similar comment
@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

Ak-sky
Ak-sky previously approved these changes Dec 2, 2025
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two references to terraform-ibm-modules/secrets-manager-public-cert/ibm in the module. The other one does not reference service_endpoints. It should also be bumped to 1.5.0.

@mukulpalit-ibm
Copy link
Contributor Author

There are two references to terraform-ibm-modules/secrets-manager-public-cert/ibm in the module. The other one does not reference service_endpoints. It should also be bumped to 1.5.0.

@shemau done

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm mukulpalit-ibm requested a review from shemau December 2, 2025 08:49
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh changed the title refactor : remove usage of service_endpoints chore: remove usage of service_endpoints Dec 2, 2025
@ocofaigh ocofaigh merged commit 2fbdb18 into main Dec 2, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 12156/remove-inappropriate-variable branch December 2, 2025 09:48
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants