-
Notifications
You must be signed in to change notification settings - Fork 0
chore: remove usage of service_endpoints #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
1 similar comment
|
/run pipeline |
shemau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two references to terraform-ibm-modules/secrets-manager-public-cert/ibm in the module. The other one does not reference service_endpoints. It should also be bumped to 1.5.0.
@shemau done |
|
/run pipeline |
shemau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 This PR is included in version 1.6.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
This PR removes the inappropriate usage of
service_endpointsvariable and replaces it withendpoint_typevariable to define how to communicate with SM for public-cert module call.Release required?
x.x.X)x.X.x)X.x.x)Release notes content
The
service_endpointsvariable is replaced withendpoint_type. This defines the secrets manager endpoint type for the terraform provider to target when creating the private certificate.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers