Skip to content

chore: remove usage of service_endpoints #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocofaigh merged 2 commits into from
Dec 2, 2025
Merged

chore: remove usage of service_endpoints #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7243389
refactor : remove usage of service_endpoints
mukulpalit-ibm Dec 1, 2025
928d149
bump version to 1.5.0
mukulpalit-ibm Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/api_key_auth/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ module "public_secret_engine" {

module "secrets_manager_public_certificate" {
source = "terraform-ibm-modules/secrets-manager-public-cert/ibm"
version = "1.4.0"
version = "1.5.0"
depends_on = [module.public_secret_engine]

cert_common_name = local.cert_common_name
Expand All @@ -87,5 +87,5 @@ module "secrets_manager_public_certificate" {
secrets_manager_guid = local.sm_guid
secrets_manager_region = local.sm_region

service_endpoints = "private"
endpoint_type = "private"
}
2 changes: 1 addition & 1 deletion examples/iam_auth/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module "public_secret_engine" {

module "secrets_manager_public_certificate" {
source = "terraform-ibm-modules/secrets-manager-public-cert/ibm"
version = "1.4.0"
version = "1.5.0"
depends_on = [module.public_secret_engine]

cert_common_name = local.cert_common_name
Expand Down