-
Notifications
You must be signed in to change notification settings - Fork 0
Create DA #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
alex-reiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't tag every instance, but within the DAs, cis should be Internet Services and sm should be Secrets Manager.
|
/run pipeline |
|
/run pipeline |
|
@Ak-sky you must be in the team github-collaborators in order to trigger the pipeline. |
|
/run pipeline |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can you review each of the variable descrption and add a "Learn more" link to the official docs which explain more information on each of the features we are expsoing to configure
- the diagram doesn't show any communcation with CIS
- can you follow up with docs team for content review please?
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
swethaisrael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aayush-Abhyarthi the doc looks good. I have added some minor comments. Please check the review comments and make the required changes if needed.
In the overall content, please make sure you add a period at the end of each description sentence.
|
/run pipeline |
swethaisrael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes. Content looks good
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments. Also I have spotted some things that are not aligned with https://github.ibm.com/GoldenEye/issues/issues/13599 - do you want to address them now? Or in a follow up PR?
|
/run pipeline |
|
@ocofaigh I will raise a separate PR for the DA improvements. |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
https://github.ibm.com/GoldenEye/issues/issues/13201
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Add a Deployable Architecture for Secrets Manager Public Certificates Engine.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers