Skip to content

Conversation

@Aayush-Abhyarthi
Copy link
Member

@Aayush-Abhyarthi Aayush-Abhyarthi commented May 8, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/13201

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add a Deployable Architecture for Secrets Manager Public Certificates Engine.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi Aayush-Abhyarthi marked this pull request as ready for review May 12, 2025 08:20
@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi Aayush-Abhyarthi changed the title DA Create DA May 20, 2025
@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Copy link
Contributor

@alex-reiff alex-reiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't tag every instance, but within the DAs, cis should be Internet Services and sm should be Secrets Manager.

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented May 26, 2025

/run pipeline

@github-actions
Copy link

@Ak-sky you must be in the team github-collaborators in order to trigger the pipeline.

@Ak-sky
Copy link
Member

Ak-sky commented May 26, 2025

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can you review each of the variable descrption and add a "Learn more" link to the official docs which explain more information on each of the features we are expsoing to configure
  • the diagram doesn't show any communcation with CIS
  • can you follow up with docs team for content review please?

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Copy link

@swethaisrael swethaisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aayush-Abhyarthi the doc looks good. I have added some minor comments. Please check the review comments and make the required changes if needed.

In the overall content, please make sure you add a period at the end of each description sentence.

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Copy link

@swethaisrael swethaisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes. Content looks good

@Ak-sky Ak-sky requested review from ocofaigh and shemau June 17, 2025 07:07
shemau
shemau previously requested changes Jun 18, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Also I have spotted some things that are not aligned with https://github.ibm.com/GoldenEye/issues/issues/13599 - do you want to address them now? Or in a follow up PR?

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

@ocofaigh I will raise a separate PR for the DA improvements.

@ocofaigh ocofaigh merged commit 1f80075 into main Jun 19, 2025
2 checks passed
@ocofaigh ocofaigh deleted the DA branch June 19, 2025 13:07
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants