test: added add-ons test #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarikaPonna
requested review from
Aayush-Abhyarthi
and removed request for
alex-reiff and
shemau
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
reviewed
Sep 23, 2025
|
/run pipeline |
ocofaigh
reviewed
Sep 23, 2025
|
/run pipeline |
|
/run pipeline |
whoffler
reviewed
Sep 30, 2025
tests/pr_test.go
Outdated
| Testing: t, | ||
| Prefix: "pbsme", | ||
| ResourceGroup: resourceGroup, | ||
| QuietMode: true, // Suppress logs except on failure |
There was a problem hiding this comment.
Have a look at similar PR where we set inputs on SMs dependencies to avoid creating too many routes in our account.
Make sure to set option OverrideInputMappings: core.BoolPtr(true) in the TestAddonOptions, it allows us to set inputs on variables that would otherwise contain a reference (otherwise SM existing_secrets_manager_crn may not be set as expected)
|
/run pipeline |
|
/run pipeline |
shemau
previously requested changes
Sep 30, 2025
|
/run pipeline |
ocofaigh
reviewed
Sep 30, 2025
|
/run pipeline |
|
/run pipeline |
ocofaigh
approved these changes
Sep 30, 2025
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.ibm.com/GoldenEye/issues/issues/15604
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers