-
Notifications
You must be signed in to change notification settings - Fork 3
ci: region selector #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: region selector #192
Conversation
|
@ocofaigh When Event Notifications was added, its region selector overrode Secrets Manager's. Is it worth writing some helper function to intersect multiple services' region rules? |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DA defaults to us-south and so us-south is used during catalog validation since we don't override the value in catalogValidationValues.json.template. We don't have the ability in the catalog pipeline to randomly select a region (although it would make a nice feature), so for now can you explicitly set it to ca-tor or br-sao in the catalogValidationValues.json.template file please?
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 1.18.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Removed us regions from test selection.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers