Skip to content

Conversation

@alex-reiff
Copy link
Contributor

Description

Removed us regions from test selection.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@alex-reiff alex-reiff requested a review from shemau as a code owner September 6, 2024 15:42
@alex-reiff
Copy link
Contributor Author

@ocofaigh When Event Notifications was added, its region selector overrode Secrets Manager's. Is it worth writing some helper function to intersect multiple services' region rules?

@alex-reiff
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DA defaults to us-south and so us-south is used during catalog validation since we don't override the value in catalogValidationValues.json.template. We don't have the ability in the catalog pipeline to randomly select a region (although it would make a nice feature), so for now can you explicitly set it to ca-tor or br-sao in the catalogValidationValues.json.template file please?

ocofaigh
ocofaigh previously approved these changes Sep 9, 2024
@ocofaigh ocofaigh dismissed their stale review September 9, 2024 09:26

incorrectly approved

@alex-reiff
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit 756e3cc into main Sep 16, 2024
@ocofaigh ocofaigh deleted the sm-regions branch September 16, 2024 17:04
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.18.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants