Skip to content

fix(deps): bump KMS with code change #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix(deps): bump KMS with code change #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5d849
fix(deps): bump KMS with code change
shemau Oct 23, 2024
4b7e42b
SKIP UPGRADE TEST
shemau Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/complete/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ This examples handles the provisioning of a new Secrets Manager instance.
| Name | Source | Version |
|------|--------|---------|
| <a name="module_event_notification"></a> [event\_notification](#module\_event\_notification) | terraform-ibm-modules/event-notifications/ibm | 1.10.17 |
| <a name="module_key_protect"></a> [key\_protect](#module\_key\_protect) | terraform-ibm-modules/kms-all-inclusive/ibm | 4.15.13 |
| <a name="module_key_protect"></a> [key\_protect](#module\_key\_protect) | terraform-ibm-modules/kms-all-inclusive/ibm | 4.16.4 |
| <a name="module_resource_group"></a> [resource\_group](#module\_resource\_group) | terraform-ibm-modules/resource-group/ibm | 1.1.6 |
| <a name="module_secrets_manager"></a> [secrets\_manager](#module\_secrets\_manager) | ../.. | n/a |

Expand Down
5 changes: 2 additions & 3 deletions examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,13 @@ module "resource_group" {

module "key_protect" {
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "4.15.13"
version = "4.16.4"
key_protect_instance_name = "${var.prefix}-key-protect"
resource_group_id = module.resource_group.resource_group_id
region = var.region
keys = [
{
key_ring_name = "${var.prefix}-sm"
force_delete_key_ring = true
key_ring_name = "${var.prefix}-sm"
keys = [
{
key_name = "${var.prefix}-sm-key"
Expand Down
7 changes: 3 additions & 4 deletions solutions/standard/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,16 @@ module "kms" {
}
count = var.existing_secrets_manager_crn != null || var.existing_secrets_manager_kms_key_crn != null ? 0 : 1 # no need to create any KMS resources if passing an existing key, or bucket
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "4.15.13"
version = "4.16.4"
create_key_protect_instance = false
region = local.kms_region
existing_kms_instance_crn = var.existing_kms_instance_crn
key_ring_endpoint_type = var.kms_endpoint_type
key_endpoint_type = var.kms_endpoint_type
keys = [
{
key_ring_name = local.kms_key_ring_name
existing_key_ring = false
force_delete_key_ring = true
key_ring_name = local.kms_key_ring_name
existing_key_ring = false
keys = [
{
key_name = local.kms_key_name
Expand Down
5 changes: 2 additions & 3 deletions tests/existing-resources/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,13 @@ module "event_notifications" {

module "key_protect" {
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "4.15.13"
version = "4.16.4"
key_protect_instance_name = "${var.prefix}-key-protect"
resource_group_id = module.resource_group.resource_group_id
region = var.region
keys = [
{
key_ring_name = "${var.prefix}-sm"
force_delete_key_ring = true
key_ring_name = "${var.prefix}-sm"
keys = [
{
key_name = "${var.prefix}-sm-key"
Expand Down