Skip to content

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Jan 29, 2025

Description

We cannot migrate the us-east hpcs to use the VPC crypto units, we will have to delete the instance. Hence, using the us-south hpcs to run the tests.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

Screenshot 2025-01-29 at 9 26 36 PM

Test ran successfully using the us-south instance.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

Screenshot 2025-01-30 at 2 48 40 PM

Complete test is passing now.
and skipping upgrade test since complete example in master branch will fail due to the no auth policy being created for service credentials.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J changed the title test: change the existing_kms_instance_guid to use us-south hpcs test: change the existing_kms_instance_guid to use us-south hpcs and add auth policy for service credential Jan 30, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to plug the test gap since the complete example only runs on upgrade. to do this, we can set CheckApplyResultForUpgrade: true in the upgrade test options

@Aashiq-J
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit a07cb0f into main Jan 30, 2025
2 checks passed
@ocofaigh ocofaigh deleted the Aashiq-J-patch-1 branch January 30, 2025 11:07
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants