feat: access group in submodule

[alex-reiff]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[alex-reiff]

/run pipeline

[alex-reiff]

/run pipeline

[alex-reiff]

/run pipeline

[alex-reiff]

/run pipeline

[alex-reiff]

/run pipeline

[alex-reiff]

/run pipeline

[alex-reiff]

/run pipeline

[ocofaigh]

Should we not be adding this support to https://github.com/terraform-ibm-modules/terraform-ibm-secrets-manager-secret-group first? The access group is mapped to a secret group, so I would of expected the logic in that module?

[alex-reiff]

@ocofaigh since this submodule and the main secrets group module are separate, does the order of implementing matter?

Doing it here first allows us to give the DA back for feedback faster.

[ocofaigh]

since this submodule and the main secrets group module are separate, does the order of implementing matter?

Doing it here first allows us to give the DA back for feedback faster.

@alex-reiff Why would you add the code in both places? Its just code duplication. Why not add the support directly to the secret-group module, and then the secrets submodule can inherit it. Or am I missing something?

[alex-reiff]

@ocofaigh Oh i think I see what you mean now.

Because access groups are gonna be 1-1 with the secrets group, they don't need to be part of the whole multi-secret-multi-secret-group object.

Yeah I'll move this into the secrets group module.

[alex-reiff]

switching to draft, main functionality moved to this PR: terraform-ibm-modules/terraform-ibm-secrets-manager-secret-group#270

[alex-reiff]

closing, functionality added in other PR