Skip to content

move kms tests off EU #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

move kms tests off EU #308

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e918d
test: move kms tests off EU
alex-reiff Mar 19, 2025
b65ee6e
test: change example defaults
alex-reiff Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/other_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ import (
func TestRunBasicExample(t *testing.T) {
t.Parallel()

var validRegions = []string{
"eu-de",
"eu-gb",
"au-syd",
}

options := testhelper.TestOptionsDefaultWithVars(&testhelper.TestOptions{
Testing: t,
TerraformDir: "examples/basic",
Expand Down
6 changes: 3 additions & 3 deletions tests/pr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ var permanentResources map[string]interface{}
// Current supported Event Notification regions
var validRegions = []string{
// "us-south", # do not run secrets manager tests in us regions
"eu-de",
"eu-gb",
"au-syd",
// "eu-de",
// "eu-gb",
"au-syd", // all tests using KMS should avoid dallas and EU regions https://github.ibm.com/GoldenEye/issues/issues/12725
}

// TestMain will be run before any parallel tests, used to read data from yaml for use with tests
Expand Down