DA rally feedback #336
DA rally feedback #336
Conversation
|
/run pipeline |
| } | ||
| } | ||
|
|
||
| variable "kms_endpoint_type" { |
There was a problem hiding this comment.
I think we can keep the variable but hide it in the ibm_catalog.json
ibm_catalog.json
Outdated
| { | ||
| "key": "event_notifications_email_list" | ||
| "key": "event_notifications_email_list", | ||
| "type": "array" |
There was a problem hiding this comment.
we need to add the custom array type for strings:
{
"key": "event_notifications_email_list",
"type": "array",
"custom_config": {
"grouping": "deployment",
"original_grouping": "deployment",
"config_constraints": {
"type": "string"
}
}
},
ibm_catalog.json
Outdated
| { | ||
| "key": "event_notifications_email_list" | ||
| "key": "event_notifications_email_list", | ||
| "type": "array" |
There was a problem hiding this comment.
we need to add the custom array type for strings:
{
"key": "event_notifications_email_list",
"type": "array",
"custom_config": {
"grouping": "deployment",
"original_grouping": "deployment",
"config_constraints": {
"type": "string"
}
}
},
| } | ||
|
|
||
| variable "skip_event_notifications_iam_authorization_policy" { | ||
| variable "skip_secrets_manager_event_notifications_iam_authorization_policy" { |
There was a problem hiding this comment.
getting very long, maybe shorten iam_authorization -> iam_auth in the name? same for the other related inputs
There was a problem hiding this comment.
in both DA variations of course
| } | ||
|
|
||
| variable "skip_sm_ce_iam_authorization_policy" { | ||
| variable "skip_secrets_manager_certificate_engine_iam_auth_policy" { |
There was a problem hiding this comment.
certificate engine is not correct here. This boolean controls the IAM credentials engine
| } | ||
|
|
||
| variable "skip_sm_ce_iam_authorization_policy" { | ||
| variable "skip_secrets_manager_certificate_engine_iam_auth_policy" { |
There was a problem hiding this comment.
certificate engine is not correct here. This boolean controls the IAM credentials engine
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
just spotted 1 more thing
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Hit list for small issues raised during DA rally, main issue: #333
Outstanding issue is how do we want to handle email validation?
skip_sm_ce_iam_authorization_policy → skip_secrets_manager_certificate_engine_iam_authorization_policy
skip_sm_ce_iam_authorization_policy - Description clarifying why to skip
allowed_network - link to corresponding sm documentation added
skip_sm_kms_iam_authorization_policy → skip_secrets_manager_kms_iam_authorization_policy (do we expand KMS too?)
ibmcloud_kms_api_key - clarify when it is(n't) needed
kms_endpoint_type → removes
event_notifications_email_list → does not use the right input widget (should be using the string array widget)
skip_event_notifications_iam_authorization_policy → skip_secrets_manager_event_notifications_iam_authorization_policy
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers