Skip to content

next steps #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2025
Merged

next steps #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b62463b
next steps
whoffler Jul 24, 2025
198833f
Clean text, update button text
whoffler Jul 24, 2025
821e263
fix typo
whoffler Jul 24, 2025
2086f40
added to sec enforced, added secondary link
whoffler Jul 25, 2025
b008de2
remove dashboard_url output
whoffler Jul 28, 2025
9a45040
align next steps with content design feedback
whoffler Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions solutions/fully-configurable/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,18 @@ output "secrets_manager_region" {
value = local.secrets_manager_region
description = "Region of the Secrets Manager instance"
}

output "next_steps_text" {
value = "Now, you can use Secrets Manager to manage sensitive data like passwords and API keys."
description = "Next steps text"
}

output "next_step_primary_label" {
value = "Go to Secrets Manager"
description = "Primary label"
}

output "next_step_primary_url" {
value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}"
Copy link
Contributor

@ocofaigh ocofaigh Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provider has a dashboard url - we should use it instead (if it works): https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_instance#dashboard_url-1

Copy link
Contributor Author

@whoffler whoffler Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashboard_url does not give us a usable URL for the resource created - 7e8ccc62-0cb0-4d57-851f-8b264699e66e.private.us-south.secrets-manager.appdomain.cloud/ui

Copy link
Contributor

@ocofaigh ocofaigh Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its producing a private endpoint url that you wont be able to hit without being logged into Global VPN. If the url construct you are doing always works lets go with that (although if the instance is in another account, the link wont work unless you switch account :( )

description = "primary url"
}
15 changes: 15 additions & 0 deletions solutions/security-enforced/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,18 @@ output "secrets_manager_crn" {
description = "CRN of Secrets Manager instance."
value = module.secrets_manager.secrets_manager_crn
}

output "next_steps_text" {
value = "Now, you can use Secrets Manager to manage sensitive data like passwords and API keys."
description = "Next steps text"
}

output "next_step_primary_label" {
value = "Go to Secrets Manager"
description = "Primary label"
}

output "next_step_primary_url" {
value = "https://cloud.ibm.com/services/secrets-manager/${module.secrets_manager.secrets_manager_crn}"
description = "primary url"
}