Skip to content

fix: Unblock dependencies #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2025
Merged

fix: Unblock dependencies #430

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3745ce
fix(deps): update dependencies
terraform-ibm-modules-ops Oct 12, 2025
b875c74
fix: disable test that fail on main branch to unblock renovate
shemau Oct 17, 2025
3b34804
Merge branch 'main' into unblock-dependencies
shemau Oct 17, 2025
ea1a486
fix: also skip other addons test
shemau Oct 17, 2025
11a5b53
Merge remote-tracking branch 'origin' into unblock-dependencies
shemau Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
call-terraform-ci-pipeline:
uses: terraform-ibm-modules/common-pipeline-assets/.github/workflows/common-terraform-module-ci-v2.yml@v1.22.5
uses: terraform-ibm-modules/common-pipeline-assets/.github/workflows/common-terraform-module-ci-v2.yml@v1.23.2
secrets: inherit
with:
craSCCv2: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ on:

jobs:
call-terraform-release-pipeline:
uses: terraform-ibm-modules/common-pipeline-assets/.github/workflows/common-release.yml@v1.22.5
uses: terraform-ibm-modules/common-pipeline-assets/.github/workflows/common-release.yml@v1.23.2
secrets: inherit
4 changes: 2 additions & 2 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "go.sum|^.secrets.baseline$|^../.secrets.baseline$",
"lines": null
},
"generated_at": "2024-03-27T22:08:26Z",
"generated_at": "2025-10-12T00:37:52Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down Expand Up @@ -77,7 +77,7 @@
}
],
"results": {},
"version": "0.13.1+ibm.62.dss",
"version": "0.13.1+ibm.64.dss",
"word_list": {
"file": null,
"hash": null
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ You need the following permissions to run this module.

| Name | Source | Version |
|------|--------|---------|
| <a name="module_cbr_rule"></a> [cbr\_rule](#module\_cbr\_rule) | terraform-ibm-modules/cbr/ibm//modules/cbr-rule-module | 1.33.2 |
| <a name="module_cbr_rule"></a> [cbr\_rule](#module\_cbr\_rule) | terraform-ibm-modules/cbr/ibm//modules/cbr-rule-module | 1.33.4 |
| <a name="module_kms_key_crn_parser"></a> [kms\_key\_crn\_parser](#module\_kms\_key\_crn\_parser) | terraform-ibm-modules/common-utilities/ibm//modules/crn-parser | 1.2.0 |
| <a name="module_secrets"></a> [secrets](#module\_secrets) | ./modules/secrets | n/a |

Expand Down
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 10 files
+2 −2 .secrets.baseline
+5 −5 da-assets/da-dependency-updater/README.md
+1 −1 da-assets/da-dependency-updater/requirements.txt
+7 −2 da-assets/da-dependency-updater/update_da_dependencies.py
+1 −1 examples/Dockerfile
+7 −9 module-assets/.pre-commit-config.yaml
+1 −0 module-assets/ci/.typos.toml
+6 −6 module-assets/ci/install-deps.sh
+2 −2 stack-assets/.pre-commit-config.yaml
+1 −1 stack-assets/stack-updater/requirements.txt
14 changes: 7 additions & 7 deletions examples/advanced/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module "resource_group" {

module "key_protect" {
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "5.1.25"
version = "5.3.4"
key_protect_instance_name = "${var.prefix}-key-protect"
resource_group_id = module.resource_group.resource_group_id
region = var.region
Expand All @@ -39,7 +39,7 @@ module "key_protect" {

module "event_notifications" {
source = "terraform-ibm-modules/event-notifications/ibm"
version = "2.7.0"
version = "2.9.3"
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-en"
tags = var.resource_tags
Expand Down Expand Up @@ -124,7 +124,7 @@ module "secrets_manager" {
# Create new code engine project
module "code_engine_project" {
source = "terraform-ibm-modules/code-engine/ibm//modules/project"
version = "4.5.13"
version = "4.6.3"
name = "${var.prefix}-project"
resource_group_id = module.resource_group.resource_group_id
}
Expand All @@ -137,7 +137,7 @@ locals {

module "code_engine_secret" {
source = "terraform-ibm-modules/code-engine/ibm//modules/secret"
version = "4.5.13"
version = "4.6.3"
name = "${var.prefix}-rs"
project_id = module.code_engine_project.id
format = "registry"
Expand All @@ -157,7 +157,7 @@ resource "ibm_cr_namespace" "rg_namespace" {
# Build example Go application in Code Engine project which dynamically generates User IBM Cloud IAM API Keys
module "code_engine_build" {
source = "terraform-ibm-modules/code-engine/ibm//modules/build"
version = "4.5.13"
version = "4.6.3"
name = "${var.prefix}-build"
region = var.region
ibmcloud_api_key = var.ibmcloud_api_key
Expand Down Expand Up @@ -186,7 +186,7 @@ locals {
module "code_engine_job" {
depends_on = [module.code_engine_build]
source = "terraform-ibm-modules/code-engine/ibm//modules/job"
version = "4.5.13"
version = "4.6.3"
name = "${var.prefix}-job"
image_reference = local.output_image
image_secret = module.code_engine_secret.name
Expand All @@ -207,7 +207,7 @@ module "code_engine_job" {
module "custom_credential_engine" {
depends_on = [module.secrets_manager, module.code_engine_job]
source = "terraform-ibm-modules/secrets-manager-custom-credentials-engine/ibm"
version = "1.0.1"
version = "1.0.4"
secrets_manager_guid = module.secrets_manager.secrets_manager_guid
secrets_manager_region = module.secrets_manager.secrets_manager_region
custom_credential_engine_name = "${var.prefix}-test-custom-engine"
Expand Down
4 changes: 2 additions & 2 deletions examples/fscloud/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ data "ibm_iam_account_settings" "iam_account_settings" {

module "cbr_zone_schematics" {
source = "terraform-ibm-modules/cbr/ibm//modules/cbr-zone-module"
version = "1.33.2"
version = "1.33.4"
name = "${var.prefix}-schematics-zone"
zone_description = "CBR Network zone containing Schematics"
account_id = data.ibm_iam_account_settings.iam_account_settings.account_id
Expand All @@ -39,7 +39,7 @@ module "cbr_zone_schematics" {

module "event_notification" {
source = "terraform-ibm-modules/event-notifications/ibm"
version = "2.7.0"
version = "2.9.3"
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-en"
tags = var.resource_tags
Expand Down
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ locals {
module "cbr_rule" {
count = length(var.cbr_rules) > 0 ? length(var.cbr_rules) : 0
source = "terraform-ibm-modules/cbr/ibm//modules/cbr-rule-module"
version = "1.33.2"
version = "1.33.4"
rule_description = var.cbr_rules[count.index].description
enforcement_mode = var.cbr_rules[count.index].enforcement_mode
rule_contexts = var.cbr_rules[count.index].rule_contexts
Expand Down
2 changes: 1 addition & 1 deletion solutions/fully-configurable/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ module "kms" {
}
count = var.existing_secrets_manager_crn == null && var.kms_encryption_enabled && var.existing_secrets_manager_kms_key_crn == null ? 1 : 0 # no need to create any KMS resources if passing an existing key
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "5.1.25"
version = "5.3.4"
create_key_protect_instance = false
region = local.kms_region
existing_kms_instance_crn = var.existing_kms_instance_crn
Expand Down
2 changes: 1 addition & 1 deletion solutions/fully-configurable/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
ibm = {
source = "IBM-Cloud/ibm"
version = "1.82.1"
version = "1.83.3"
}
time = {
source = "hashicorp/time"
Expand Down
4 changes: 2 additions & 2 deletions tests/existing-resources/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module "resource_group" {

module "event_notifications" {
source = "terraform-ibm-modules/event-notifications/ibm"
version = "2.7.0"
version = "2.9.3"
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-en"
tags = var.resource_tags
Expand All @@ -31,7 +31,7 @@ module "event_notifications" {

module "key_protect" {
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "5.1.25"
version = "5.3.4"
key_protect_instance_name = "${var.prefix}-key-protect"
resource_group_id = module.resource_group.resource_group_id
region = var.region
Expand Down
43 changes: 22 additions & 21 deletions tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@ module github.com/terraform-ibm-modules/terraform-ibm-secrets-manager

go 1.24.2

toolchain go1.25.1
toolchain go1.25.2

require (
github.com/IBM/go-sdk-core/v5 v5.21.0
github.com/gruntwork-io/terratest v0.50.0
github.com/gruntwork-io/terratest v0.51.0
github.com/stretchr/testify v1.11.1
github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper v1.60.9
github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper v1.60.12
)

require (
dario.cat/mergo v1.0.0 // indirect
github.com/IBM-Cloud/bluemix-go v0.0.0-20240719075425-078fcb3a55be // indirect
github.com/IBM-Cloud/power-go-client v1.12.0 // indirect
github.com/IBM/cloud-databases-go-sdk v0.8.0 // indirect
github.com/IBM/platform-services-go-sdk v0.86.1 // indirect
github.com/IBM/project-go-sdk v0.3.6 // indirect
github.com/IBM-Cloud/power-go-client v1.13.0 // indirect
github.com/IBM/cloud-databases-go-sdk v0.8.1 // indirect
github.com/IBM/platform-services-go-sdk v0.89.0 // indirect
github.com/IBM/project-go-sdk v0.3.9 // indirect
github.com/IBM/schematics-go-sdk v0.4.0 // indirect
github.com/IBM/vpc-go-sdk v1.0.2 // indirect
github.com/Microsoft/go-winio v0.6.2 // indirect
Expand All @@ -35,22 +35,23 @@ require (
github.com/ghodss/yaml v1.0.0 // indirect
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
github.com/go-git/go-billy/v5 v5.6.2 // indirect
github.com/go-git/go-git/v5 v5.16.2 // indirect
github.com/go-git/go-git/v5 v5.16.3 // indirect
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-openapi/analysis v0.23.0 // indirect
github.com/go-openapi/errors v0.22.2 // indirect
github.com/go-openapi/errors v0.22.3 // indirect
github.com/go-openapi/jsonpointer v0.21.1 // indirect
github.com/go-openapi/jsonreference v0.21.0 // indirect
github.com/go-openapi/loads v0.22.0 // indirect
github.com/go-openapi/runtime v0.28.0 // indirect
github.com/go-openapi/spec v0.21.0 // indirect
github.com/go-openapi/strfmt v0.23.0 // indirect
github.com/go-openapi/strfmt v0.24.0 // indirect
github.com/go-openapi/swag v0.23.1 // indirect
github.com/go-openapi/validate v0.24.0 // indirect
github.com/go-playground/locales v0.14.1 // indirect
github.com/go-playground/universal-translator v0.18.1 // indirect
github.com/go-playground/validator/v10 v10.26.0 // indirect
github.com/go-viper/mapstructure/v2 v2.4.0 // indirect
github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect
github.com/google/go-cmp v0.7.0 // indirect
github.com/google/uuid v1.6.0 // indirect
Expand All @@ -62,7 +63,7 @@ require (
github.com/hashicorp/go-safetemp v1.0.0 // indirect
github.com/hashicorp/go-version v1.7.0 // indirect
github.com/hashicorp/hcl/v2 v2.22.0 // indirect
github.com/hashicorp/terraform-json v0.26.0 // indirect
github.com/hashicorp/terraform-json v0.27.2 // indirect
github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
github.com/jinzhu/copier v0.4.0 // indirect
github.com/josharian/intern v1.0.0 // indirect
Expand All @@ -74,7 +75,6 @@ require (
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/mitchellh/go-testing-interface v1.14.1 // indirect
github.com/mitchellh/go-wordwrap v1.0.1 // indirect
github.com/mitchellh/mapstructure v1.5.0 // indirect
github.com/nxadm/tail v1.4.11 // indirect
github.com/oklog/ulid v1.3.1 // indirect
github.com/opentracing/opentracing-go v1.2.0 // indirect
Expand All @@ -86,21 +86,22 @@ require (
github.com/tmccombs/hcl2json v0.6.4 // indirect
github.com/ulikunitz/xz v0.5.11 // indirect
github.com/xanzy/ssh-agent v0.3.3 // indirect
github.com/zclconf/go-cty v1.16.3 // indirect
go.mongodb.org/mongo-driver v1.17.3 // indirect
github.com/zclconf/go-cty v1.16.4 // indirect
go.mongodb.org/mongo-driver v1.17.4 // indirect
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
go.opentelemetry.io/otel v1.35.0 // indirect
go.opentelemetry.io/otel/metric v1.35.0 // indirect
go.opentelemetry.io/otel/trace v1.35.0 // indirect
golang.org/x/crypto v0.41.0 // indirect
golang.org/x/mod v0.26.0 // indirect
golang.org/x/net v0.42.0 // indirect
go.yaml.in/yaml/v2 v2.4.2 // indirect
golang.org/x/crypto v0.43.0 // indirect
golang.org/x/mod v0.28.0 // indirect
golang.org/x/net v0.45.0 // indirect
golang.org/x/sync v0.17.0 // indirect
golang.org/x/sys v0.35.0 // indirect
golang.org/x/text v0.28.0 // indirect
golang.org/x/tools v0.35.0 // indirect
golang.org/x/sys v0.37.0 // indirect
golang.org/x/text v0.30.0 // indirect
golang.org/x/tools v0.37.0 // indirect
gopkg.in/warnings.v0 v0.1.2 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
sigs.k8s.io/yaml v1.4.0 // indirect
sigs.k8s.io/yaml v1.6.0 // indirect
)
Loading