Skip to content

ci: disable CRA #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

ci: disable CRA #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2539768
ci: disable CRA
ocofaigh Mar 31, 2025
af29ee7
checkov ignore
ocofaigh Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions chart/cloud-pak-deployer/templates/install-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ metadata:
labels:
App: {{ .Values.deployer.prefix }}
annotations:
# https://github.com/terraform-ibm-modules/terraform-ibm-cloudpak-data/issues/14
checkov.io/skip1: CKV_K8S_10
checkov.io/skip2: CKV_K8S_11
checkov.io/skip3: CKV_K8S_12
Expand All @@ -27,6 +28,7 @@ metadata:
checkov.io/skip19: CKV_K8S_16
checkov.io/skip20: CKV_K8S_8
checkov.io/skip21: CKV_K8S_43
checkov.io/skip22: CKV2_K8S_6
spec:
backoffLimit: 0
completions: 1
Expand Down
2 changes: 2 additions & 0 deletions chart/cloud-pak-deployer/templates/uninstall-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ metadata:
"helm.sh/hook": pre-delete
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded,hook-failed
"helm.sh/hook-weight": "4"
# https://github.com/terraform-ibm-modules/terraform-ibm-cloudpak-data/issues/14
checkov.io/skip1: CKV_K8S_21
checkov.io/skip2: CKV_K8S_30
checkov.io/skip3: CKV_K8S_28
Expand All @@ -29,6 +30,7 @@ metadata:
checkov.io/skip18: CKV_K8S_12
checkov.io/skip19: CKV_K8S_13
checkov.io/skip20: CKV_K8S_14
checkov.io/skip21: CKV2_K8S_6
spec:
parallelism: 1
completions: 1
Expand Down
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 13 files
+47 −14 common-go-assets/common-permanent-resources.yaml
+1 −1 examples/Dockerfile
+20 −12 module-assets/.pre-commit-config.yaml
+0 −4 module-assets/Makefile
+7 −7 module-assets/ci/install-deps.sh
+20 −4 module-assets/ci/terraformDocOverview.py
+172 −0 module-assets/ci/validateIbmCatalogJson.py
+18 −5 module-assets/ci/validateJsonTemplate.py
+0 −6 module-assets/docker.env
+0 −13 renovate.json
+1 −1 scripts/update-source/requirements.txt
+3 −6 stack-assets/.pre-commit-config.yaml
+3 −3 stack-assets/stack-updater/requirements.txt
18 changes: 9 additions & 9 deletions cra-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
#

version: "v1"
CRA_TARGETS:
- CRA_TARGET: "examples/basic" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json"
PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
# SCC_INSTANCE_ID: "" # The SCC instance ID to use to download profile for CRA scan. If not provided, a default global value will be used.
# SCC_REGION: "" # The IBM Cloud region that the SCC instance is in. If not provided, a default global value will be used.
CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs.
TF_VAR_prefix: "roks-cpd"
TF_VAR_region: "au-syd"
CRA_TARGETS: [] # disable CRA since no SCC instance exists in the test account
# - CRA_TARGET: "examples/basic" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
# CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json"
# PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
# # SCC_INSTANCE_ID: "" # The SCC instance ID to use to download profile for CRA scan. If not provided, a default global value will be used.
# # SCC_REGION: "" # The IBM Cloud region that the SCC instance is in. If not provided, a default global value will be used.
# CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs.
# TF_VAR_prefix: "roks-cpd"
# TF_VAR_region: "au-syd"