Skip to content

feat: onboard cloudpak 4 data #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 26, 2025
Merged

feat: onboard cloudpak 4 data #34

merged 15 commits into from
Jun 26, 2025

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jun 4, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jun 4, 2025
@jor2 jor2 requested a review from argeiger as a code owner June 4, 2025 23:22
argeiger
argeiger previously approved these changes Jun 5, 2025
View reviewed changes
@jor2
Copy link
Member Author

jor2 commented Jun 10, 2025

successfully deployed using existing cluster - https://cloud.ibm.com/projects/08ef9093-8a07-4e29-a5e8-ad51d40b2f7d/configurations

ocofaigh
ocofaigh requested changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

ocofaigh
ocofaigh reviewed Jun 10, 2025
View reviewed changes
ocofaigh
ocofaigh reviewed Jun 10, 2025
View reviewed changes
ocofaigh
ocofaigh reviewed Jun 10, 2025
View reviewed changes
@jor2 jor2 requested review from argeiger and ocofaigh June 10, 2025 10:14
ocofaigh
ocofaigh requested changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see latest

@jor2 jor2 requested a review from ocofaigh June 11, 2025 10:00
argeiger
argeiger requested changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@argeiger argeiger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. Just added one thing surrounding the README and pre-reqs that we should document

@jor2
Copy link
Member Author

jor2 commented Jun 11, 2025

/run pipeline

4 similar comments
@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

argeiger
argeiger previously approved these changes Jun 12, 2025
View reviewed changes
@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025 

TestRunStandardSolution 2025-06-12T14:47:25Z command.go:206: module.watsonx_self_managed_ocp.module.cloud_pak_deployer.helm_release.cloud_pak_deployer_helm_release: Still destroying... [id=cloud-pak-deployer, 10m0s elapsed]
TestRunStandardSolution 2025-06-12T14:47:26Z command.go:206: ╷
TestRunStandardSolution 2025-06-12T14:47:26Z command.go:206: │ Error: 1 error occurred:
TestRunStandardSolution 2025-06-12T14:47:26Z command.go:206: │ 	* timed out waiting for the condition

timed out on destroy

@jor2
Copy link
Member Author

jor2 commented Jun 12, 2025

/run pipeline

@argeiger
Copy link
Contributor

/run pipeline

@argeiger
Copy link
Contributor

/run pipeline

@argeiger
Copy link
Contributor

/run pipeline

@argeiger
Copy link
Contributor

/run pipeline

argeiger
argeiger previously approved these changes Jun 16, 2025
View reviewed changes
@ocofaigh
Copy link
Contributor

/run pipeline

ocofaigh
ocofaigh previously approved these changes Jun 25, 2025
View reviewed changes
@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh
Copy link
Contributor

Going to merge this once pipeline green - @argeiger should it be a 2.0.0 release?

@argeiger
Copy link
Contributor

Going to merge this once pipeline green - @argeiger should it be a 2.0.0 release?

Yes we can mark it as a 2.0.0 so we know that is the start of the catalog version

@ocofaigh ocofaigh merged commit 4621893 into main Jun 26, 2025
2 checks passed
@ocofaigh ocofaigh deleted the onboarding branch June 26, 2025 16:51
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

3 similar comments
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@argeiger argeiger argeiger approved these changes

@ocofaigh ocofaigh ocofaigh left review comments

Assignees

@jor2 jor2

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jor2 @argeiger @ocofaigh @terraform-ibm-modules-ops