Skip to content

Conversation

@argeiger
Copy link
Contributor

@argeiger argeiger commented Jan 13, 2025

Description

Update logic for build through shell script and also update the uninstall script

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger argeiger requested a review from vburckhardt January 13, 2025 23:24
@@ -0,0 +1,38 @@
#!/bin/bash

BUILD_OUTPUT=$(curl -X POST "https://api.${REGION}.codeengine.cloud.ibm.com/v2/projects/${PROJECT_ID}/build_runs" -H "Authorization: ${TOKEN}" -H "Content-Type: application/json" -d '{ "build_name": "cpd-build" }')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do create the project/build/etc through the code engine DA. The problem is executing a build run and checking for completion which there is no terraform for

@argeiger
Copy link
Contributor Author

/run pipeline

@vburckhardt vburckhardt self-requested a review January 14, 2025 15:35
@argeiger argeiger merged commit dd3abc8 into main Jan 14, 2025
2 checks passed
@argeiger argeiger deleted the image-build-updates branch January 14, 2025 17:10
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants