Skip to content

Conversation

@surfaceflinger
Copy link
Contributor

Required by velero-plugin-for-aws since 1.9.0

vmware-tanzu/velero-plugin-for-aws#218
vmware-tanzu/velero-plugin-for-aws@4c71526

↪️ Pull Request

  • Make sure you are opening from a feature/feat/docs/fix/bug/hotfix/stable/chore (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry

📒 Description

🕶️ Types of changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation
  • Dependencies

🤯 List of changes

  • Add missing S3 permission for velero-plugin-for-aws

👫 Relationships

🔎 Review hints

🚨 Test instructions

Just run the newer version of velero-plugin-for-aws

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • Added/updated unit tests for this change
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
  • Filled out test instructions (In case there aren't any unit tests)
  • I followed the existing code standards and didn't mess up the formatting.
  • My change requires a change to the documentation.
  • I did my best to add documentation to any public classes or methods I added.
  • Included links to related issues/PRs

Required by velero-plugin-for-aws since 1.9.0
@surfaceflinger
Copy link
Contributor Author

Would be also useful to tag a new release with this

@stale
Copy link

stale bot commented Apr 29, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@stale stale bot added the stale label Apr 29, 2025
@surfaceflinger
Copy link
Contributor Author

Not stale

@stale stale bot removed the stale label Apr 29, 2025
@surfaceflinger
Copy link
Contributor Author

@ivankatliarchuk could you review/merge? Thanks

@ivankatliarchuk ivankatliarchuk merged commit f77c825 into terraform-module:master Apr 29, 2025
2 checks passed
@ivankatliarchuk
Copy link
Member

Done. Thank you

@surfaceflinger surfaceflinger deleted the fix/iam-perms-fix branch April 29, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants