OCM-22297 | ci: Fixing id:72514,id:72478, upgrade tests, disabling IMDS tests for now#1070
OCM-22297 | ci: Fixing id:72514,id:72478, upgrade tests, disabling IMDS tests for now#1070jerichokeyne wants to merge 1 commit intoterraform-redhat:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
…g flaky IMDS tests for now
23e1997 to
ed5f7ef
Compare
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerichokeyne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@jerichokeyne: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it: This is fixing a few CI failures that have been coming up lately
id:72514- assumed that you can't create a node pool with autoscaling enabled andmin_replicasset to0, but that actually seems to work fineid:72478- tried to change the channel group toeus, but that channel group only has even numbered y-stream versions. I switched it to try to use either thefastorcandidatechannel groups as those both seem to have the same versions asstable(which is required for the edit to succeed)tests/e2e/hcp_image_mirror_test.gohave been very flaky since they've been introduced. Until we have time to re-write those tests I'm excluding the entire test suite to minimize the number of false negatives we getchannelproperty on the cluster before listing the y-stream upgrades due to a recent API change. I also noticed that we had separate test cases for HCP clusters vs classic clusters, but they only seemed to really differ by a single line, so I combined the 4 test cases down to 2 test cases (y-stream vs z-stream) for nowupgrade_acknowledgements_forfield isn't actually working properly. I'm still trying to narrow down the issue, but I don't think it's related to my testing code changes at all as this was a known issue before as well. I tested z-stream upgrades for classic clusters, and didn't see any issuesocm-sdk-golibrary version to be able to set the newchannelpropertyWhich issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):Fixes #OCM-22297
Change type
Checklist
Local logs: