Skip to content

OCM-22297 | ci: Fixing id:72514,id:72478, upgrade tests, disabling IMDS tests for now#1070

Open
jerichokeyne wants to merge 1 commit intoterraform-redhat:mainfrom
jerichokeyne:OCM-22297
Open

OCM-22297 | ci: Fixing id:72514,id:72478, upgrade tests, disabling IMDS tests for now#1070
jerichokeyne wants to merge 1 commit intoterraform-redhat:mainfrom
jerichokeyne:OCM-22297

Conversation

@jerichokeyne
Copy link
Contributor

@jerichokeyne jerichokeyne commented Feb 19, 2026

What this PR does / why we need it: This is fixing a few CI failures that have been coming up lately

  • id:72514 - assumed that you can't create a node pool with autoscaling enabled and min_replicas set to 0, but that actually seems to work fine
  • id:72478 - tried to change the channel group to eus, but that channel group only has even numbered y-stream versions. I switched it to try to use either the fast or candidate channel groups as those both seem to have the same versions as stable (which is required for the edit to succeed)
  • A lot of the tests under tests/e2e/hcp_image_mirror_test.go have been very flaky since they've been introduced. Until we have time to re-write those tests I'm excluding the entire test suite to minimize the number of false negatives we get
  • The upgrades tests needed updating to set the channel property on the cluster before listing the y-stream upgrades due to a recent API change. I also noticed that we had separate test cases for HCP clusters vs classic clusters, but they only seemed to really differ by a single line, so I combined the 4 test cases down to 2 test cases (y-stream vs z-stream) for now
    • I've tested that both z-stream and y-stream upgrades work well for HCP clusters
    • I've tested y-stream upgrades for classic clusters, but ran into an issue where it doesn't work on the first apply, but does work on the second apply. I think there may be either a provider bug or an API bug where the upgrade_acknowledgements_for field isn't actually working properly. I'm still trying to narrow down the issue, but I don't think it's related to my testing code changes at all as this was a known issue before as well. I tested z-stream upgrades for classic clusters, and didn't see any issues
    • I also had to update the ocm-sdk-go library version to be able to set the new channel property

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):
Fixes #OCM-22297

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Local logs:

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jerichokeyne
Copy link
Contributor Author

/retest

@yuwang-RH
Copy link
Contributor

/lgtm

@jerichokeyne
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerichokeyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olucasfreitas
Copy link
Contributor

/retest-required

1 similar comment
@olucasfreitas
Copy link
Contributor

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2026

@jerichokeyne: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit ed5f7ef link true /test e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants