ISSUE-885 | feat: Implement no-cni for HCP clusters#1074
ISSUE-885 | feat: Implement no-cni for HCP clusters#1074paulczar wants to merge 4 commits intoterraform-redhat:mainfrom
Conversation
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @paulczar. Thanks for your PR. I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
reviving PR-903
Makes it possible to configure a HCP cluster without a CNI, like with rosa cluster create --no-cni
Implementing it like the rosa CLI does it: https://github.com/openshift/rosa/blob/4f425f6d857bb7b1ddb7af8fc69a25d25ce8fae3/pkg/ocm/clusters.go#L939
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):
Fixes #885