feat(cartodiagram): add polygon merge and configurable area mask rendering#44
Open
pierrejego wants to merge 4 commits intoterrestris:5.0.0-customfrom
Open
feat(cartodiagram): add polygon merge and configurable area mask rendering#44pierrejego wants to merge 4 commits intoterrestris:5.0.0-customfrom
pierrejego wants to merge 4 commits intoterrestris:5.0.0-customfrom
Conversation
- Reuse parsed OpenLayers features to avoid repeated geometry parsing - Fit map from existing features instead of re-parsing records - Simplify feature construction in dataRecordsToOlFeatures
clarify dataFeatures usage and clean up OlChartMap
…ering link to discussion apache#38692 apache#38692
Author
|
This PR had been made on top of #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR improves polygon rendering in the
plugin-chart-cartodiagramfor filtered thematic maps.It introduces two optional visualization features for polygon geometries:
The goal is to improve readability when working with administrative boundaries at different levels, especially when cross-filtering or focusing on aggregated areas.
Main changes:
Merge Polygon Entitiesas an optional chart setting;Show Area Maskas an optional chart setting;Implementation note:
the merge logic is display-oriented and based on shared edge detection after coordinate normalization. It is not a full topological union or buffer-based dissolve.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screenshots/GIF can be added here if needed.
TESTING INSTRUCTIONS
plugin-chart-cartodiagramwith polygon geometries.Merge Polygon Entitiesin the chart customization panel.Merged Polygon Stroke WidthandMerged Polygon Stroke Color.Show Area Mask.Area Mask OpacityandArea Mask Color.ADDITIONAL INFORMATION