Open
Conversation
… in editable mode
…WFS JSON and restore baseline behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes four issues in superset_wfs_dialect that caused errors in superset when loading and cross-filtering charts based on specific WFS.
WfsDialect.dbapi()andWfsDialect.import_dbapi()now return the concretewfs_dbapiobject frombase.pyand avoid errors like module'superset_wfs_dialect' has no attribute 'paramstyle'unexpected character: line 1 column 1caused by attempting to parse XML as JSON. This is a fallback. Requests may fail for long or complex filters (e.g. due to URL length). The root cause is a misconfiguration of the requested WFS service, which returns XML/GML instead of JSON for POST GetFeature despite requesting JSON (needs to be discussed). We keep [Bug]: Crossfilter funktioniert nicht auf bestimmtem WFS #54 open as this feature needs to be discussed further (46d5a85)In addition, the README file will be updated to include instructions for integrating the dialect module into a superset development environment (372ded3).