Enhance filter handling for OR expressions and simplify null cases#59
Open
mholthausen wants to merge 1 commit intomainfrom
Open
Enhance filter handling for OR expressions and simplify null cases#59mholthausen wants to merge 1 commit intomainfrom
mholthausen wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes cross-filtering on
<NULL>values and closes #56 .When selecting
<NULL>/N/Ain superset cross-filters, superset can generate SQL like:Those patterns are valid SQL but not directly valid as WFS property filters.
Therefore, the dialect previously failed in two ways:
ORexpressions were not supported at allIN (NULL),1 != 1) were tranformed literally to FES, which led to invalid WFS filters (e.g. ValueReference=1) and server errorsWith the changes in this PR
ORsupport in filter conversion and a filter pre-processing for special casesIN (NULL)and1 != 1are added here.Now expressions like
sperrart IS NULL OR sperrart IN (NULL) AND (1 != 1)are reduced to a valid FES filter (sperrart IS NULL) before tranformation.