Skip to content

Enhance filter handling for OR expressions and simplify null cases#59

Open
mholthausen wants to merge 1 commit intomainfrom
fix/56-crossfilter-null-fes-filter
Open

Enhance filter handling for OR expressions and simplify null cases#59
mholthausen wants to merge 1 commit intomainfrom
fix/56-crossfilter-null-fes-filter

Conversation

@mholthausen
Copy link
Member

@mholthausen mholthausen commented Mar 24, 2026

This fixes cross-filtering on <NULL> values and closes #56 .

When selecting <NULL> / N/A in superset cross-filters, superset can generate SQL like:

sperrart IS NULL OR sperrart IN (NULL) AND (1 != 1)

Those patterns are valid SQL but not directly valid as WFS property filters.

Therefore, the dialect previously failed in two ways:

  1. OR expressions were not supported at all
  2. SQLAlchemy expressions (IN (NULL), 1 != 1) were tranformed literally to FES, which led to invalid WFS filters (e.g. ValueReference=1) and server errors

With the changes in this PR OR support in filter conversion and a filter pre-processing for special cases IN (NULL) and 1 != 1 are added here.

Now expressions like sperrart IS NULL OR sperrart IN (NULL) AND (1 != 1) are reduced to a valid FES filter (sperrart IS NULL) before tranformation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Crossfiltern auf NULL Werte funktioniert nicht

1 participant