[feat] Auto MAC addr detection #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
See tesla-local-control/tesla-local-control-addon#32 Anyways, referencing this issue that will be solved with this: tesla-local-control/tesla-local-control-addon#31 |
baylanger
force-pushed
the
auto-macaddr-detection
branch
2 times, most recently
from
2eafe0d to
261ed7c
Compare
baylanger
force-pushed
the
auto-macaddr-detection
branch
from
261ed7c to
43b0f2f
Compare
raphmur
reviewed
Jul 15, 2024
raphmur
reviewed
Jul 15, 2024
baylanger
force-pushed
the
auto-macaddr-detection
branch
2 times, most recently
from
0592886 to
7d1a7d1
Compare
iainbullock
reviewed
Jul 16, 2024
Contributor
iainbullock
left a comment
iainbullock
left a comment
There was a problem hiding this comment.
Excellent work and a very useful new feature, many thanks
A lot of changes. Have either of you tested it before we merge into #main?
I could create a _docker branch and use it to test, however I might not complete it today
Contributor
Author
Yes I have been testing throughout the dev process but more tester is always good. I did create the addon PR but not for Docker. Will do if you don't have time and that I get the time. |
Contributor
|
Ok shall we merge into core? I don't think there's a lot to do for _docker from what I can see. Eg Anything else? I can do that later no problem |
baylanger
force-pushed
the
auto-macaddr-detection
branch
2 times, most recently
from
8dc140e to
1cccd0f
Compare
raphmur
reviewed
Jul 16, 2024
Contributor
raphmur
left a comment
raphmur
left a comment
There was a problem hiding this comment.
Me likey likey!
Happy to test.
baylanger
force-pushed
the
auto-macaddr-detection
branch
from
f044e9a to
2f3e335
Compare
raphmur
previously approved these changes
Jul 16, 2024
iainbullock
approved these changes
Jul 16, 2024
baylanger
added a commit
that referenced
this pull request
Jul 25, 2024
* [chg] auto Generate Keys to ReGenerateKeys (#89) * [feat] Info Bluetooth Adapter (#88) * [feat] Info Bluetooth Adapter (#88) (#90) * [fix] counter loop condition * [fix] topic & missing retry values (#92) * [chg] delete old scan-bleln-macaddr * [feat] Auto MAC address detection (#86) * small rewrite logic to detect MAC addr * [chg] skip menu mgmt (#96) * [fix] Prevent presence unknown, set qos=1 (#97) * [fix] Prevent presence unknown, set qos=1 * [CHG] info-bt-adapter; run mgmt.info before show * [CHG] Presence disable? Set Unknown and Delete * [CHG] CHANGELOG Update * [fix] presence unkown at start * [fix] presence unkown at start * Update subroutines.sh shfmt * Update mqtt-discovery.sh shfmt * [issue 99] Buttons to switches covers merged with PR85 (#105) * [chg] Add loop to generate JSON enteties based on a paramater list * Merge with 85 * [chg] run.sh add -e to ash (#95) * [Feature-Issue #99] Transform buttons to switches & covers; Add Cmds & Icons (#103) * Group entities * Update CHANGELOG.md * Reorder legacies cleaning * tabs to spaces (shfmt) * Anticipate clearing MQTT entities * shfmt * add newline * [feat] Transform buttons to switches & covers; Add Commands & Icons * Make delete_legacies* vin aware * Add/fix icons; adjust CHANGELOG * [chg] revert ash -e * [chg] add back media-ctrl, remove ping * [chg] changelog add new commands --------- Co-authored-by: Pierre Belanger <[email protected]> * [chg] raise tesla-control command timeout (#108) * [chg] changelog add note on command-timeout (#109) * [chg] raise tesla-control command timeout * [chg] changelog add note on command-timeout * [chg] remove arguments to tesla-control and use env vars --------- Co-authored-by: Iain Bullock <[email protected]> Co-authored-by: Raphael Murray <[email protected]>
raphmur
added a commit
that referenced
this pull request
Sep 14, 2024
* [chg] auto Generate Keys to ReGenerateKeys (#89) * [feat] Info Bluetooth Adapter (#88) * [feat] Info Bluetooth Adapter (#88) (#90) * [fix] counter loop condition * [fix] topic & missing retry values (#92) * [chg] delete old scan-bleln-macaddr * [feat] Auto MAC address detection (#86) * small rewrite logic to detect MAC addr * [chg] skip menu mgmt (#96) * [fix] Prevent presence unknown, set qos=1 (#97) * [fix] Prevent presence unknown, set qos=1 * [CHG] info-bt-adapter; run mgmt.info before show * [CHG] Presence disable? Set Unknown and Delete * [CHG] CHANGELOG Update * [fix] presence unkown at start * [fix] presence unkown at start * Update subroutines.sh shfmt * Update mqtt-discovery.sh shfmt * [issue 99] Buttons to switches covers merged with PR85 (#105) * [chg] Add loop to generate JSON enteties based on a paramater list * Merge with 85 * [chg] run.sh add -e to ash (#95) * [Feature-Issue #99] Transform buttons to switches & covers; Add Cmds & Icons (#103) * Group entities * Update CHANGELOG.md * Reorder legacies cleaning * tabs to spaces (shfmt) * Anticipate clearing MQTT entities * shfmt * add newline * [feat] Transform buttons to switches & covers; Add Commands & Icons * Make delete_legacies* vin aware * Add/fix icons; adjust CHANGELOG * [chg] revert ash -e * [chg] add back media-ctrl, remove ping * [chg] changelog add new commands --------- Co-authored-by: Pierre Belanger <[email protected]> * [chg] raise tesla-control command timeout (#108) * [chg] changelog add note on command-timeout (#109) * [chg] raise tesla-control command timeout * [chg] changelog add note on command-timeout * [chg] remove arguments to tesla-control and use env vars * [fix] body-controller-state (#111) * [feat] allow to set temperature_unit F|C (#110) * [fix] body-controller-state (#112) (#118) Co-authored-by: Pierre Belanger <[email protected]> * Fix charging set amps log (#116) * Update mqtt-listen.sh * Wake in case of command failure (#120) * parse "context deadline exceeded" * bump version * doc * Fix nested calls * 121 add max current env setting (#122) * Add MAX_CURRENT setting * Add contributor --------- Co-authored-by: Pierre Belanger <[email protected]> Co-authored-by: Iain Bullock <[email protected]> Co-authored-by: g4rb4g3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.