chore: remove SimpleCov code-coverage tooling - #425
Open
tas50 wants to merge 1 commit into
Open
Conversation
The opt-in coverage report was never gated, never run in CI, and never consulted -- it only added a dev dependency and a `COVERAGE=1` branch in the spec bootstrap that every contributor had to read past. Removes the simplecov gem, the `SimpleCov.start` block in spec/spec_helper.rb, the `rake coverage` task, the `coverage` artifact path in .gitignore, and the CONTRIBUTING.md prose describing them. The YARD documentation-coverage task (`rake doc_stats`) is unrelated and is deliberately kept. Signed-off-by: Tim Smith <tim@mondoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the SimpleCov code-coverage machinery. It was opt-in (
COVERAGE=1), never gated, never run in CI, and never consulted — so all it bought us was a dev dependency and an extra branch in the spec bootstrap.Removed:
Gemfilegem "simplecov", require: falsefrom the:testgroupspec/spec_helper.rbif ENV["COVERAGE"]block,require "simplecov", andSimpleCov.startRakefiledesc "Run the unit tests with coverage reporting"/task :coveragetask and itsENV["COVERAGE"] = "1".gitignorecoverageartifact pathCONTRIBUTING.mdrake coverage/COVERAGE=1invocations and the "Coverage is reported but not gated" paragraphThere was no
minimum_coverage/minimum_coverage_by_fileenforcement, nothing underspec/support/referenced SimpleCov, and no CI workflow uploaded or reported coverage — so nothing to remove there. The gemspec never carried the dependency either.YARD documentation coverage is deliberately kept
The
Rakefilealso hasdesc "Report YARD documentation coverage"/task :doc_stats. That is documentation coverage, not code coverage, and it is untouched. Confirmed still present and working:Verification
Nothing left in the tree:
Test counts unchanged before and after the removal:
Lint clean, on the same cookstyle line CI resolves (
Gemfile.lockis gitignored, so CI takes the newest in~> 9.0):CI on this PR has not finished at the time of writing.
Open PRs / merge order
No conflicts, and no merge order required. None of the open PRs touch
Gemfile,Rakefile, orspec/spec_helper.rb:fix:shell argv) —lib/kitchen/driver/dokken.rb,lib/kitchen/transport/dokken.rb,spec/kitchen/driver/dokken_spec.rb,spec/kitchen/transport/dokken_spec.rbfix:user_ns_mode) —README.md,lib/kitchen/driver/dokken.rb,spec/kitchen/driver/create_payload_spec.rb.release-please-manifest.json,CHANGELOG.md,lib/kitchen/driver/dokken_version.rbThis PR touches only
Gemfile,Rakefile,spec/spec_helper.rb,.gitignore, andCONTRIBUTING.md, so it can merge in any order relative to the others.(#424, the README docs PR, has already merged as
5a7474e.)