feat(tart provider): Consolidate VM name logic and add vendor to .gitignore #523
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@copilot git ignore the vendor directory and try again! |
…ignore - Rework Vagrantfile.erb to consolidate two separate case blocks into one for setting p.name - Add support for tart provider VM naming (without UUID suffix) - Add test coverage for tart provider - Add vendor directory to .gitignore to prevent bundler dependencies from being committed Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
[WIP] Rework logic for improved functionality
feat(tart provider): Consolidate VM name logic and add vendor to .gitignore
Nov 11, 2025
damacus
approved these changes
Nov 30, 2025
Stromweld
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the tart provider in kitchen-vagrant by consolidating the VM name setting logic, addressing the review feedback from PR #503.
Changes Made
case config[:provider]blocks into a single one for settingp.nameintemplates/Vagrantfile.erb, improving code maintainabilitykitchen-<root>-<instance>instead ofkitchen-<root>-<instance>-<uuid>)spec/kitchen/driver/vagrant_spec.rbfor the tart provider VM naming behaviorvendordirectory to prevent bundler dependencies from being committed to the repositoryBackground
The tart provider (https://github.com/letiemble/vagrant-tart) for Vagrant enables Test Kitchen to work with tart VMs (https://github.com/cirruslabs/tart). This PR follows the review feedback suggesting to consolidate duplicate case statements rather than having separate blocks for VM name configuration.
Testing
The changes are minimal and focused, following existing code patterns in the repository.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.