Conversation
CharlieM312
force-pushed
the
feature/node-24-update
branch
3 times, most recently
from
11f1bd9 to
f90fc99
Compare
|
Thanks for the change! This PR is pretty large — 2560 additions & 4324 deletions — and a lot of that looks like formatting changes. 🥴 It's hard to review a large diff, especially when a lot of it is just noisy formatting changes that are noops. Can you not include formatting changes with the functional changes so that this is easier to review? If you think the formatting changes are useful, having each in a separate commit (so that they can be reviewed separately) would be grand. If they're not useful then let's not even make them in the first place. 🙏 |
CharlieM312
force-pushed
the
feature/node-24-update
branch
from
f90fc99 to
12c1c46
Compare
|
Hi @ethomson, I've removed all formatting changes and just kept the functional ones, PR should be a lot smaller now |
CharlieM312
force-pushed
the
feature/node-24-update
branch
from
12c1c46 to
5966676
Compare
| } | ||
|
|
||
| let show = TestStatus.Fail | ||
| let show: number = TestStatus.Fail |
There was a problem hiding this comment.
show is being directly compared to a number below hence me adding this
| const normalizeDetails = (value: string | undefined) => | ||
| value?.replace(/\r\n/g, "\n").trimEnd() | ||
|
|
||
| expect(normalizeDetails(case_with_message.details)).to.eql( |
There was a problem hiding this comment.
Fixes a failing test due to just line spacing/trim issues it seems
| import * as util from "util" | ||
| import * as core from "@actions/core" | ||
| import * as glob from "glob-promise" | ||
| import * as glob from "glob" |
There was a problem hiding this comment.
glob-promise is now part of glob so updated it and changed the package around
You can hide whitespace changes. |
Thank you @CharlieM312 ! 🙏 I appreciate it. |
3 participants
Updates to change the action to use node24