docs: document 28 of the existing rust community modules #142
Conversation
modules/postgresql/index.md
Outdated
|
|
||
| let postgres_instance = postgres::Postgres::default().start().unwrap(); | ||
|
|
||
| let connection_string = format!( |
There was a problem hiding this comment.
suggestion: here in the catalog, we usually just add the container instance declaration, avoiding the addition of more in depth info on how to connect to them. We delegate that to the final docs for each language
There was a problem hiding this comment.
fair enough. I just copied the examples from docs.rs ^^
Not quite sure what this means concretely for the modules as noted below 😅
modules/mssql/index.md
Outdated
| maintainer: community | ||
| example: | | ||
| ```rust | ||
| use testcontainers_modules::{testcontainers::runners::SyncRunner, mssql_server}; |
There was a problem hiding this comment.
this one needs accepting the eula.. lets keep it ^^
| url: https://docs.rs/testcontainers-modules/latest/testcontainers_modules/oracle/free/struct.Oracle.html | ||
| maintainer: community | ||
| example: | | ||
| ```rust |
There was a problem hiding this comment.
lets keep the warning ^^
| maintainer: community | ||
| example: | | ||
| ```rust | ||
| use testcontainers::core::ImageExt; |
There was a problem hiding this comment.
since this does not work otherwise, here I am keeping the imports.
It is otherwise a bit confusing
There was a problem hiding this comment.
It's technically possible to call this like <.. as testcontainers::core::ImageExt>
But I definitely agree that import is way better for trait here
|
@mdelapenya is there any feedback for me to integrate? |
| maintainer: community | ||
| example: | | ||
| ```rust | ||
| use testcontainers::core::ImageExt; |
There was a problem hiding this comment.
It's technically possible to call this like <.. as testcontainers::core::ImageExt>
But I definitely agree that import is way better for trait here
Co-authored-by: Artem Medvedev <[email protected]>
Co-authored-by: Artem Medvedev <[email protected]>
|
@CommanderStorm I'll delegate the final review to @DDtKey, as core maintainer of tc-rust, not being myself a rust developer. Once approved, I can merge this PR In any case, your humungous work in updating all the modules is amazing, thank you so much for this. The TC catalog will look amazing for the Rust community! 🚀 |
|
Well.. this is only like 50% of the modules avaliable. |
There are quite a few rust modules missing.
These are just the modules for which there already exists a file.
CC @DDtKey