-
-
Notifications
You must be signed in to change notification settings - Fork 338
fix(Elasticsearch): Use HTTP wait strategy #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+132
−31
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
20d3bd3
fix #1592
digital88 d798b07
Merge branch 'develop' into bug-1592
digital88 69a8d47
fix nitpicks
digital88 dafdf65
fix nitpicks
digital88 c1e02f5
fix
digital88 bd15f24
chore: Align with other module implemenations
HofmeisterAn 86148f7
docs(Elasticsearch): Align docs
HofmeisterAn 04e32d5
fix: Close doc reference
HofmeisterAn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to not work for 7.x.x images, which don't have security enabled by default. So even though neither of the
"xpack.security.enabled"or"xpack.security.http.ssl.enabled"environment variables are provided, Elasticsearch still expects HTTP, butElasticsearchConfigurationassumes HTTPS.HttpWaitStrategythen gets stuck in a loop, as it catches the following exception and returnsfalse.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please test and set the environment variables explicitly to
false?I believe the expression is incorrect when SSL is not enabled by default. For version 8, you need to disable it explicitly. The
has...variables will befalsefor images that don't have SSL enabled by default (like version 7).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a workaround I ended up with. If variables are there and are set to
false, thenTlsEnabledis evaluated tofalseand HTTP is used, just as expected.Perhaps you need to also check the tag and apply different logic for versions less than 8, where HTTPS is not enabled by default. Or maybe there is some better option.
And possibly handle that specific exception and rethrow it with a clear message indicating protocol mismatch instead of swallowing it.