feat(mssql): add WithInitSQL function

[MattiasMTS]

What does this PR do?

Add WithInitSQL function to facilitate any initial e.g. DDL scripts to be processed before testing against the container.

Why is it important?

It will improve developer experience and follow the same conventions that exist for other modules, e.g. mysql.

How to test this PR

Run the make test in the folder and it should run. I am using podman, so I modify the containerprovider during that time but should work as is if you're using docker

[netlify]

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	e6bdc71
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/67bd7d2abad8a3000821b4c7
😎 Deploy Preview	https://deploy-preview-2988--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mdelapenya]

I left some comments that need to be addressed before accepting the PR.

It's also important to add the new option to the docs at ./docs/modules/mssql.md, that will land into our docs here: https://golang.testcontainers.org/modules/mssql/

Other than that, the PR looks good, we just need to talk about my comments.

Thanks for your work and time here 🙇

[MattiasMTS]

It's also important to add the new option to the docs at ./docs/modules/mssql.md, that will land into our docs here: https://golang.testcontainers.org/modules/mssql/

Sure, I was a bit unsure on adding that myself or if it was generated. As for the structure, ok if I follow the previous conventions or do I need to add e.g. the tag of upcoming release this feature will be included in?

[stevenh]

Thanks for the updates, here's some more feedback based on the latest version

[mdelapenya]

or do I need to add e.g. the tag of upcoming release this feature will be included in?

Yes, please use the following block:

- Not available until the next release of testcontainers-go <a href="https://github.com/testcontainers/testcontainers-go"><span class="tc-version">:material-tag: main</span></a>

[MattiasMTS]

Well, it's as they say

thanks for the comments @mdelapenya and @stevenh. Should be ready for somewhat of a final review.

Do you want to extend the scope of WithScripts to support other types of executable, e.g. *.sh etc. I see that is quite typical based on previous modules.

[stevenh]

Thanks for the quick updates, think we're getting close.

Did you see the replies to other threads about using PATH instead of parsing custom image?

[stevenh]

Well, it's as they say .. thanks for the comments @mdelapenya and @stevenh. Should be ready for somewhat of a final review.

Yer sorry, we've been trying to bring some improvement to the code base, which means that the patterns that you see elsewhere have changed, thanks for your patience and quick changes it really helps!

Do you want to extend the scope of WithScripts to support other types of executable, e.g. *.sh etc. I see that is quite typical based on previous modules.

Good question, as you say some modules are using this for scripts as well as pure data (sql).

I would not have expected that until you mentioned it, I wonder if Scripts is causing the ambiguity, is there a better term? Possibly WithSQL?

[MattiasMTS]

Renamed it to WithInitSQL and also updated the code to use PATH as you suggested, which reduced a bunch of code which is nice.

[stevenh]

Thanks for all your work on this, hope you managed to take away some learnings as I did.

[stevenh]

@MattiasMTS could you update the PR title and description to match the code please

[stevenh]

@mdelapenya my suggestion to include t.Context() fails because its 1.24 we should consider bumping to 1.24 instead of 1.23 to take advantage of that.

In the mean time @MattiasMTS feel free to change that back to context.Background() so we don't delay this PR any further.

[MattiasMTS]

Done. I also added a test of an old image to verify the PATH of sqlcmd works backwards compatible.

[mdelapenya]

we should consider bumping to 1.24 instead of 1.23 to take advantage of that.

@stevenh we usually develop the library following Go's release policy: https://golang.testcontainers.org/system_requirements/#go-version, which means we always develop the library in the lower supported version (1.23 at the moment)

[MattiasMTS]

Hi @mdelapenya sorry for late feedback on this, totally forgot it. I fixed the linting now, hopefully should be mergable. Thanks.

[mdelapenya]

LGTM, thanks for your time working on this 🙇