Skip to content

chore(ci): try Shipfox #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdelapenya wants to merge 8 commits into
base: main
Choose a base branch
from
+20 −20
Open

chore(ci): try Shipfox #3268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
af054ef
chore(ci): try Shipfox
mdelapenya Aug 25, 2025
d2a3d9b
Merge branch 'main' into try-shipfox
mdelapenya Sep 4, 2025
c8107ab
Merge branch 'main' into try-shipfox
mdelapenya Oct 6, 2025
4332883
Merge branch 'main' into try-shipfox
mdelapenya Nov 20, 2025
2a2ac47
Merge branch 'main' into try-shipfox
mdelapenya Dec 3, 2025
7544234
Merge branch 'main' into try-shipfox
mdelapenya Dec 24, 2025
5d8427e
Merge branch 'main' into try-shipfox
mdelapenya Jan 2, 2026
e06a456
chore: change runner in the new workflow
mdelapenya Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-lint-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ permissions:
jobs:
lint-go-project:
name: "lint: ${{ inputs.project-directory }}"
runs-on: 'ubuntu-latest'
runs-on: 'shipfox-2vcpu-ubuntu-2404'
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-test-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
platforms:
required: true
type: string
default: "ubuntu-latest"
default: "shipfox-2vcpu-ubuntu-2404"
Copy link

@coderabbitai coderabbitai bot Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove either required: true or the default value.

The platforms input is marked as required: true but also has a default value. If an input is required, its default value will never be used since callers must always provide a value. This creates confusion about the intended behavior.

🔎 Recommended fix

Choose one approach:

Option 1: Remove the default if the value must always be explicitly provided:

       platforms:
         required: true
         type: string
-        default: "shipfox-2vcpu-ubuntu-2404"
         description: "The platforms in which the project will be run"

Option 2: Remove required: true if the default should be used when not specified:

       platforms:
-        required: true
+        required: false
         type: string
         default: "shipfox-2vcpu-ubuntu-2404"
         description: "The platforms in which the project will be run"

Based on the workflow design where callers explicitly provide platform matrices (see ci.yml lines 72, 95, 116, 137), Option 1 appears more appropriate.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
default: "shipfox-2vcpu-ubuntu-2404"
platforms:
required: true
type: string
description: "The platforms in which the project will be run"
🧰 Tools
🪛 actionlint (1.7.9)

14-14: input "platforms" of workflow_call event has the default value "shipfox-2vcpu-ubuntu-2404", but it is also required. if an input is marked as required, its default value will never be used

(events)

🤖 Prompt for AI Agents 
In .github/workflows/ci-test-go.yml around line 14, the `platforms` input is
marked `required: true` while also providing a default value; remove this
contradiction by deleting the default value so callers must explicitly provide
platforms (Option 1), or alternatively remove `required: true` if you want the
default to be used; based on existing callers, remove the default value to
enforce explicit input.

description: "The platforms in which the project will be run"
project-directory:
required: true
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
if: always()

- name: Decide if Sonar must be run
if: ${{ matrix.platform == 'ubuntu-latest' }}
if: ${{ matrix.platform == 'shipfox-2vcpu-ubuntu-2404' }}
run: |
if [[ "1.24.x" == "${{ inputs.go-version }}" ]] && \
[[ "true" != "${{ inputs.rootless-docker }}" ]] && \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-windows-trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
windows-test-command-trigger:
permissions:
pull-requests: write # for peter-evans/slash-command-dispatch to create PR reaction
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404

steps:
- name: Trigger windows-test command
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency:

jobs:
detect-modules:
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
Copy link

@coderabbitai coderabbitai bot Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

cat -n .github/workflows/ci.yml | head -160

Repository: testcontainers/testcontainers-go

Length of output: 6552

🏁 Script executed:

#!/bin/bash
# Check for Ubuntu version references in codebase
echo "=== Checking for Ubuntu version references ==="
rg "ubuntu-2[0-9]|jammy|noble" --type yaml --type sh --type toml --type md -n

echo -e "\n=== Checking for Docker version constraints ==="
rg "docker.*version|DOCKER_VERSION|DOCKER_BUILDKIT" -n --type yaml --type sh --type toml

echo -e "\n=== Checking for kernel version or system-specific constraints ==="
rg "uname|kernel.*version|lsb_release" -n --type yaml --type sh

Repository: testcontainers/testcontainers-go

Length of output: 444

🏁 Script executed:

# Check if there are any known issues or compatibility notes for Ubuntu 24.04 in docs
echo "=== Checking for compatibility notes or setup documentation ==="
find . -maxdepth 2 -type f \( -name "README*" -o -name "SETUP*" -o -name "*.md" \) | head -10 | xargs grep -l "ubuntu\|docker\|24.04\|noble" 2>/dev/null | head -5

Repository: testcontainers/testcontainers-go

Length of output: 147

🏁 Script executed:

#!/bin/bash
# Check for other CI workflow files
echo "=== Other workflow files ==="
find .github/workflows -type f -name "*.yml" -o -name "*.yaml" | sort

echo -e "\n=== Check for README or infrastructure docs ==="
find . -maxdepth 2 -type f \( -name "README*" -o -name "CONTRIBUTING*" -o -name "*INFRA*" \) | head -10

echo -e "\n=== Look for any documentation on runners or CI ==="
find . -type f -name "*.md" | xargs grep -l "shipfox\|runner\|ubuntu.*24" 2>/dev/null | head -5

Repository: testcontainers/testcontainers-go

Length of output: 953

🏁 Script executed:

# Check ci-test-go.yml to understand how the platform parameter is used
echo "=== Checking ci-test-go.yml for platform usage ==="
cat .github/workflows/ci-test-go.yml | head -100

Repository: testcontainers/testcontainers-go

Length of output: 3633

🏁 Script executed:

# Look for any fallback logic or GitHub runner configuration elsewhere
echo "=== Checking for github.io or other runner configurations ==="
rg "runs-on|ubuntu-latest|macos-latest|windows-latest" .github/workflows/ -A 2 -B 2

Repository: testcontainers/testcontainers-go

Length of output: 6218

Verify Ubuntu 24.04 compatibility for non-modulegen modules and ensure fallback strategy is documented.

The Shipfox runner is already established across the CI infrastructure. However, non-modulegen modules lack fallback runners. Before merging, verify:

  1. Ubuntu 24.04 compatibility: Confirm that testcontainers functionality works correctly with Ubuntu 24.04's Docker version and kernel behavior. The modulegen module already tests on macOS and Windows; consider extending cross-platform validation to other modules if applicable.

  2. Fallback strategy for standard modules: Unlike modulegen (which tests on shipfox-2vcpu-ubuntu-2404, macos-latest, and windows-latest), other modules test only on the Shipfox runner. Document whether this is intentional or whether a fallback to GitHub-hosted runners should be added.

🧰 Tools
🪛 actionlint (1.7.9)

15-15: label "shipfox-2vcpu-ubuntu-2404" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-11-arm", "ubuntu-slim", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-26-xlarge", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🤖 Prompt for AI Agents 
In .github/workflows/ci.yml around line 15, the workflow pins runs-on to
shipfox-2vcpu-ubuntu-2404 but there is no verification or documented fallback
for non-modulegen modules; confirm testcontainers and all CI-dependent tooling
are compatible with Ubuntu 24.04 (Docker/kernel behavior) and either document
that compatibility check and rationale for using only the Shipfox runner, or add
a fallback matrix entry to run tests on GitHub-hosted runners (e.g.,
ubuntu-latest and/or macos-latest/windows-latest) for standard modules; update
the CI file and repository docs to reflect the chosen approach and the
verification steps performed.

outputs:
modules: ${{ steps.set-modified-modules.outputs.modules }}
modules_count: ${{ steps.set-modified-modules-count.outputs.modules_count }}
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
uses: ./.github/workflows/ci-test-go.yml
with:
go-version: ${{ matrix.go-version }}
platforms: ${{ matrix.module == 'modulegen' && '["ubuntu-latest", "macos-latest", "windows-latest"]' || '["ubuntu-latest"]' }}
platforms: ${{ matrix.module == 'modulegen' && '["shipfox-2vcpu-ubuntu-2404", "macos-latest", "windows-latest"]' || '["shipfox-2vcpu-ubuntu-2404"]' }}
project-directory: "${{ matrix.module }}"
testcontainers-cloud: false
rootless-docker: false
Expand All @@ -92,7 +92,7 @@ jobs:
uses: ./.github/workflows/ci-test-go.yml
with:
go-version: ${{ matrix.go-version }}
platforms: '["ubuntu-latest"]'
platforms: '["shipfox-2vcpu-ubuntu-2404"]'
project-directory: "."
testcontainers-cloud: true
rootless-docker: false
Expand All @@ -113,7 +113,7 @@ jobs:
uses: ./.github/workflows/ci-test-go.yml
with:
go-version: ${{ matrix.go-version }}
platforms: '["ubuntu-latest"]'
platforms: '["shipfox-2vcpu-ubuntu-2404"]'
project-directory: "."
testcontainers-cloud: false
rootless-docker: false
Expand All @@ -134,7 +134,7 @@ jobs:
uses: ./.github/workflows/ci-test-go.yml
with:
go-version: ${{ matrix.go-version }}
platforms: '["ubuntu-latest"]'
platforms: '["shipfox-2vcpu-ubuntu-2404"]'
project-directory: "."
testcontainers-cloud: false
rootless-docker: true
Expand All @@ -146,7 +146,7 @@ jobs:
needs:
- detect-modules
- test
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
steps:
- name: Check if any jobs failed
if: ${{ failure() || cancelled() }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
# - https://gh.io/supported-runners-and-hardware-resources
# - https://gh.io/using-larger-runners
# Consider using larger runners for possible analysis time improvements.
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'shipfox-2vcpu-ubuntu-2404' }}
timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }}
permissions:
actions: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conventions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
lint-pr:
name: Validate PR title follows Conventional Commits
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
steps:
- uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 # v6
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docker-projects-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
containerd-integration: [true, false]

name: "Core tests using latest moby/moby"
runs-on: 'ubuntu-latest'
runs-on: 'shipfox-2vcpu-ubuntu-2404'
continue-on-error: true
steps:
- name: Set the Docker Install type
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
latest_compose-spec_version: false

name: "Compose tests using a local copy of the compose and compose-spec projects"
runs-on: 'ubuntu-latest'
runs-on: 'shipfox-2vcpu-ubuntu-2404'
continue-on-error: true
steps:
- name: Check out code into the Go module directory
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
permissions:
contents: write # for release-drafter/release-drafter to create a github release
pull-requests: write # for release-drafter/release-drafter to add label to PR
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
steps:
- uses: release-drafter/release-drafter@b1476f6e6eb133afa41ed8589daba6dc69b4d3f5 # v6.1.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scorecards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions: read-all
jobs:
analysis:
name: Scorecard analysis
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
permissions:
# Needed if using Code scanning alerts
security-events: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonar-bulk-operations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
bulk-operation:
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonar-create-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
create-project:
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonar-delete-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
delete-project:
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/usage-metrics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ env:

jobs:
collect-metrics:
runs-on: ubuntu-latest
runs-on: shipfox-2vcpu-ubuntu-2404
timeout-minutes: 120
steps:
- name: Checkout repository
Expand Down
Loading