Skip to content

Commit d2906fd

Browse files
authored
Adjust wording of pre-flight check messages to be clearer (#457)
* Adjust wording of pre-flight check messages to be clearer when presented as an AssertionError. Replaces #436. * Update changelog
1 parent 8eea37c commit d2906fd

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
1414
### Changed
1515
- Load `DockerClientProviderStrategy` via Service Loader (#434, #435)
1616
- Make it possible to specify docker compose container in configuration (#422, #425)
17+
- Clarify wording of pre-flight check messages (#457, #436)
1718

1819

1920
## [1.4.2] - 2017-07-25

core/src/main/java/org/testcontainers/DockerClientFactory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public boolean matches(Object o) {
142142

143143
@Override
144144
public void describeTo(Description description) {
145-
description.appendText("is newer than 1.6.0");
145+
description.appendText("should be at least 1.6.0");
146146
}
147147
});
148148
}
@@ -162,7 +162,7 @@ private void checkDiskSpace(DockerClient dockerClient, String id) {
162162
DiskSpaceUsage df = parseAvailableDiskSpace(outputStream.toString());
163163

164164
VisibleAssertions.assertTrue(
165-
"Docker environment has more than 2GB free",
165+
"Docker environment should have more than 2GB free disk space",
166166
df.availableMB.map(it -> it >= 2048).orElse(true)
167167
);
168168
}
@@ -187,7 +187,7 @@ private void checkExposedPort(String hostIpAddress, DockerClient dockerClient, S
187187
} catch (IOException e) {
188188
response = e.getMessage();
189189
}
190-
VisibleAssertions.assertEquals("Exposed port is accessible", "hello", response);
190+
VisibleAssertions.assertEquals("A port exposed by a docker container should be accessible", "hello", response);
191191
}
192192

193193
/**

0 commit comments

Comments
 (0)