Skip to content

Commit f588082

Browse files
authored
Fix mp4 recording to be compatible with Firefox (#3812)
Firefox still doesn't support yuv444 so use yuv420p https://shallowsky.com/blog/linux/videos-from-images.html
1 parent eaf9b9f commit f588082

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

core/src/main/java/org/testcontainers/containers/VncRecordingContainer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ String reencodeRecording(@NonNull VncRecordingContainer container, @NonNull Stri
132132
@Override
133133
String reencodeRecording(@NonNull VncRecordingContainer container, @NonNull String source) throws IOException, InterruptedException {
134134
String newFileOutput = "/newScreen.mp4";
135-
container.execInContainer("ffmpeg", "-i", source, "-vcodec", "libx264", "-movflags", "faststart", newFileOutput);
135+
container.execInContainer("ffmpeg", "-i", source, "-vcodec", "libx264", "-movflags", "faststart", "-pix_fmt", "yuv420p", newFileOutput);
136136
return newFileOutput;
137137
}
138138
};

0 commit comments

Comments
 (0)