Add default database name to MongoDB Atlas#10034
Merged
eddumelendez merged 2 commits intotestcontainers:mainfrom Apr 3, 2025
blancqua:feat/expose_database_name_mongodbatlas
Merged
Add default database name to MongoDB Atlas#10034eddumelendez merged 2 commits intotestcontainers:mainfrom blancqua:feat/expose_database_name_mongodbatlas
eddumelendez merged 2 commits intotestcontainers:mainfrom
blancqua:feat/expose_database_name_mongodbatlas
Conversation
luketn
suggested changes
Feb 26, 2025
Contributor
luketn
left a comment
luketn
left a comment
There was a problem hiding this comment.
Good idea! Only change I would recommend is using the term 'database specific connection string' because:
- connectionString is more consistent with the existing getConnectionString() method
- the database specific connection string is not related to replica sets. it's just a way to include the database name in the connection string rather than having to select a database afterward
modules/mongodb/src/main/java/org/testcontainers/mongodb/MongoDBAtlasLocalContainer.java
Show resolved
Hide resolved
Author
|
Sounds good to me! Included your suggestion and merged them all together in 1 commit. |
eddumelendez
requested changes
Feb 26, 2025
modules/mongodb/src/main/java/org/testcontainers/mongodb/MongoDBAtlasLocalContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/mongodb/MongoDBAtlasLocalContainer.java
Show resolved
Hide resolved
Author
|
@eddumelendez, spotless changes applied. One flaky test (ArtemisContainerTest), but I don't see this having anything to do with the proposed change. Kind regards, Wouter |
Author
|
Hi guys, anything else you would like to see changed before this can be merged? |
Author
|
Hello @eddumelendez, @luketn. I'm reaching out since this is now open for a while. Anything still holding you back from merging this? Kind regards, |
Member
|
Thanks for your contribution, @blancqua! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion #10031