upgrade to fix commons-compress CVEs#10149
Closed
FerencKemeny wants to merge 1 commit intotestcontainers:mainfrom
Closed
upgrade to fix commons-compress CVEs#10149FerencKemeny wants to merge 1 commit intotestcontainers:mainfrom
FerencKemeny wants to merge 1 commit intotestcontainers:mainfrom
Conversation
…and vulnerabilities from dependencies: CVE-2024-47554
Member
|
Hi, thanks for raising the issue. I have shared before in one of the issues why we are not upgrading. We need to keep compatibility with other projects. Do you have proves that the CVEs are not false-positives? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had troubles with upgrading testcontainers dependencies in my projects to the latest version. Nexus is blocking it because of transitive vulnerabilities detected from commons-compress. Maven Repository is also indicating CVE-2024-26308 and CVE-2024-25710.
I decided to get on the bottom of it and resolve the issues around upgrading. I am aware you have Dependabot configured to perform upgrading weekly. However commons-compress is on the ignore list - I guess because of the runtime issues. I managed to resolve those relatively simply. Please find the fix in my PR. You may consider even removing the Dependabot ignore but I leave it up to your decision.