Add GaussDB testcontainers module#10195
Closed
tsohnugo wants to merge 11 commits intotestcontainers:mainfrom
Closed
Add GaussDB testcontainers module#10195tsohnugo wants to merge 11 commits intotestcontainers:mainfrom
tsohnugo wants to merge 11 commits intotestcontainers:mainfrom
Conversation
GaussDB is adapted to testcontainers
liubao68
reviewed
Apr 27, 2025
Comment on lines
+69
to
+75
| final String password; | ||
| if ("gaussdb".equalsIgnoreCase(connectionUrl.getDatabaseType())){ | ||
| // At least one uppercase, lowercase, numeric, special character, and password length(8). | ||
| password = connectionUrl.getQueryParameters().getOrDefault(pwdParamName, "Test@123"); | ||
| }else { | ||
| password = connectionUrl.getQueryParameters().getOrDefault(pwdParamName, "test"); | ||
| } |
There was a problem hiding this comment.
I think this modification is not necessary.
Author
There was a problem hiding this comment.
If jdbc:tc connection is used, the default password is test, which does not conform to the password specification of GaussDB, resulting in the failure to create the container
Member
|
Hi @tsohnugo, thanks for your contribution. Next time, please reach out before raising a PR for a new module. Manage issues and PRs would require extra knowledge from the team. I suggest you can host the module and share it in our Official Module Catalog by raising a PR in testcontainers/community-module-registry. We will be happy to support best practices for the module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,GaussDB is a distributed relational database independently innovated and developed by Huawei.
This pr add the New Modules: GaussDB