Skip to content

Fix parameter check in Kafka cluster examples #10361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 3 commits into from
Aug 12, 2025
+23 −15
Merged

Fix parameter check in Kafka cluster examples #10361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16f037a
fix parameter check in Kafka cluster examples
winfriedgerlach Jun 12, 2025
d0d9f2e
Merge branch 'main' into scout/parameter-check-in-kafka-cluster-examples
eddumelendez Aug 12, 2025
b0d69e2
Fix format
eddumelendez Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...les/kafka-cluster/src/test/java/com/example/kafkacluster/ApacheKafkaContainerCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ public class ApacheKafkaContainerCluster implements Startable {
private final Collection<KafkaContainer> brokers;

public ApacheKafkaContainerCluster(String version, int brokersNum, int internalTopicsRf) {
if (brokersNum < 0) {
if (brokersNum <= 0) {
throw new IllegalArgumentException("brokersNum '" + brokersNum + "' must be greater than 0");
}
if (internalTopicsRf < 0 || internalTopicsRf > brokersNum) {
if (internalTopicsRf <= 0 || internalTopicsRf > brokersNum) {
throw new IllegalArgumentException(
"internalTopicsRf '" + internalTopicsRf + "' must be less than brokersNum and greater than 0"
"internalTopicsRf '" +
internalTopicsRf +
"' must be less than or equal to brokersNum and greater than 0"
);
}

Expand Down Expand Up @@ -99,6 +101,6 @@ public void start() {

@Override
public void stop() {
this.brokers.stream().parallel().forEach(GenericContainer::stop);
this.brokers.parallelStream().forEach(GenericContainer::stop);
}
}
10 changes: 6 additions & 4 deletions .../kafka-cluster/src/test/java/com/example/kafkacluster/ConfluentKafkaContainerCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ public class ConfluentKafkaContainerCluster implements Startable {
private final Collection<ConfluentKafkaContainer> brokers;

public ConfluentKafkaContainerCluster(String confluentPlatformVersion, int brokersNum, int internalTopicsRf) {
if (brokersNum < 0) {
if (brokersNum <= 0) {
throw new IllegalArgumentException("brokersNum '" + brokersNum + "' must be greater than 0");
}
if (internalTopicsRf < 0 || internalTopicsRf > brokersNum) {
if (internalTopicsRf <= 0 || internalTopicsRf > brokersNum) {
throw new IllegalArgumentException(
"internalTopicsRf '" + internalTopicsRf + "' must be less than brokersNum and greater than 0"
"internalTopicsRf '" +
internalTopicsRf +
"' must be less than or equal to brokersNum and greater than 0"
);
}

Expand Down Expand Up @@ -100,6 +102,6 @@ public void start() {

@Override
public void stop() {
this.brokers.stream().parallel().forEach(GenericContainer::stop);
this.brokers.parallelStream().forEach(GenericContainer::stop);
}
}
8 changes: 5 additions & 3 deletions examples/kafka-cluster/src/test/java/com/example/kafkacluster/KafkaContainerCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ public class KafkaContainerCluster implements Startable {
private final Collection<KafkaContainer> brokers;

public KafkaContainerCluster(String confluentPlatformVersion, int brokersNum, int internalTopicsRf) {
if (brokersNum < 0) {
if (brokersNum <= 0) {
throw new IllegalArgumentException("brokersNum '" + brokersNum + "' must be greater than 0");
}
if (internalTopicsRf < 0 || internalTopicsRf > brokersNum) {
if (internalTopicsRf <= 0 || internalTopicsRf > brokersNum) {
throw new IllegalArgumentException(
"internalTopicsRf '" + internalTopicsRf + "' must be less than brokersNum and greater than 0"
"internalTopicsRf '" +
internalTopicsRf +
"' must be less than or equal to brokersNum and greater than 0"
);
}

Expand Down
10 changes: 6 additions & 4 deletions ...ples/kafka-cluster/src/test/java/com/example/kafkacluster/KafkaContainerKraftCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ public class KafkaContainerKraftCluster implements Startable {
private final Collection<KafkaContainer> brokers;

public KafkaContainerKraftCluster(String confluentPlatformVersion, int brokersNum, int internalTopicsRf) {
if (brokersNum < 0) {
if (brokersNum <= 0) {
throw new IllegalArgumentException("brokersNum '" + brokersNum + "' must be greater than 0");
}
if (internalTopicsRf < 0 || internalTopicsRf > brokersNum) {
if (internalTopicsRf <= 0 || internalTopicsRf > brokersNum) {
throw new IllegalArgumentException(
"internalTopicsRf '" + internalTopicsRf + "' must be less than brokersNum and greater than 0"
"internalTopicsRf '" +
internalTopicsRf +
"' must be less than or equal to brokersNum and greater than 0"
);
}

Expand Down Expand Up @@ -101,6 +103,6 @@ public void start() {

@Override
public void stop() {
this.brokers.stream().parallel().forEach(GenericContainer::stop);
this.brokers.parallelStream().forEach(GenericContainer::stop);
}
}
Loading