-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add support to configure system password for Oracle database #10601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
079a494
1630f95
ec95b8f
6e0ac92
63752c5
3e63f05
bf19086
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -58,6 +58,18 @@ public class OracleContainer extends JdbcDatabaseContainer<OracleContainer> { | |||||
|
|
||||||
| private String password = APP_USER_PASSWORD; | ||||||
|
|
||||||
| /** | ||||||
| * Password for Oracle system user (e.g. SYSTEM/SYS). Defaults to {@link #APP_USER_PASSWORD} | ||||||
| * for backwards compatibility, but can be customized independently via {@link #withOraclePassword(String)}. | ||||||
| */ | ||||||
| private String oraclePassword = APP_USER_PASSWORD; | ||||||
|
|
||||||
| /** | ||||||
| * Tracks whether {@link #withOraclePassword(String)} was called to avoid overriding | ||||||
| * the system password when {@link #withPassword(String)} is used for the application user only. | ||||||
| */ | ||||||
| private boolean oraclePasswordExplicitlySet = false; | ||||||
|
||||||
| private boolean oraclePasswordExplicitlySet = false; | |
| private boolean systemPasswordExplicitlySet = false; |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| public OracleContainer withOraclePassword(String oraclePassword) { | |
| public OracleContainer withSystemPassword(String oraclePassword) { |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,20 @@ private void runTest(OracleContainer container, String databaseName, String user | |
| assertThat(resultSetInt).as("A basic SELECT query succeeds").isEqualTo(1); | ||
| } | ||
|
|
||
| private void runTestSystemUser(OracleContainer container, String databaseName, String username, String password) | ||
| throws SQLException { | ||
| //Test config was honored | ||
|
||
| assertThat(container.getDatabaseName()).isEqualTo(databaseName); | ||
| assertThat(container.getUsername()).isEqualTo(username); | ||
| assertThat(container.getPassword()).isEqualTo(password); | ||
|
|
||
| //Test we can get a connection and execute a system-level command | ||
|
||
| container.start(); | ||
| ResultSet resultSet = performQuery(container, "GRANT DBA TO " + username); | ||
| int resultSetInt = resultSet.getInt(1); | ||
| assertThat(resultSetInt).as("A basic system user query succeeds").isEqualTo(1); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDefaultSettings() throws SQLException { | ||
| try (OracleContainer oracle = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME);) { | ||
|
|
@@ -77,7 +91,7 @@ public void testCustomUser() throws SQLException { | |
| @Test | ||
| public void testSID() throws SQLException { | ||
| try (OracleContainer oracle = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME).usingSid();) { | ||
| runTest(oracle, "xepdb1", "system", "test"); | ||
| runTestSystemUser(oracle, "xepdb1", "system", "test"); | ||
|
|
||
| // Match against the last ':' | ||
| String urlSuffix = oracle.getJdbcUrl().split("(\\:)(?!.*\\:)", 2)[1]; | ||
|
|
@@ -92,7 +106,29 @@ public void testSIDAndCustomPassword() throws SQLException { | |
| .usingSid() | ||
| .withPassword("testPassword"); | ||
| ) { | ||
| runTest(oracle, "xepdb1", "system", "testPassword"); | ||
| runTestSystemUser(oracle, "xepdb1", "system", "testPassword"); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testSeparateSystemAndAppPasswords() throws SQLException { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should have two tests instead? |
||
| // SID mode should use system password | ||
|
||
| try ( | ||
| OracleContainer oracleSid = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME) | ||
| .usingSid() | ||
| .withOraclePassword("SysP@ss1!") | ||
| .withPassword("AppP@ss1!") | ||
| ) { | ||
| runTestSystemUser(oracleSid, "xepdb1", "system", "SysP@ss1!"); | ||
| } | ||
|
|
||
| // Non-SID mode should use application user's password | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove the comment |
||
| try ( | ||
| OracleContainer oraclePdb = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME) | ||
| .withOraclePassword("SysP@ss2!") | ||
| .withPassword("AppP@ss2!") | ||
| ) { | ||
| runTest(oraclePdb, "xepdb1", "test", "AppP@ss2!"); | ||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.