Skip to content

Move LocalStack tests to JUnit Jupiter #10746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 1 commit into from
Sep 4, 2025
+445 −453
Merged

Move LocalStack tests to JUnit Jupiter #10746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/localstack/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ description = "Testcontainers :: Localstack"
dependencies {
api project(':testcontainers')

testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'

testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
testImplementation platform("software.amazon.awssdk:bom:2.32.29")
testImplementation 'software.amazon.awssdk:s3'
testImplementation 'software.amazon.awssdk:sqs'
Expand All @@ -17,3 +20,7 @@ tasks.japicmp {
"org.testcontainers.containers.localstack.LocalStackContainer"
]
}

test {
useJUnitPlatform()
}
218 changes: 91 additions & 127 deletions ...les/localstack/src/test/java/org/testcontainers/containers/localstack/LegacyModeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,154 +1,118 @@
package org.testcontainers.containers.localstack;

import com.github.dockerjava.api.DockerClient;
import lombok.AllArgsConstructor;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.experimental.runners.Enclosed;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
import org.testcontainers.DockerClientFactory;
import org.testcontainers.containers.localstack.LocalStackContainer.Service;
import org.testcontainers.images.RemoteDockerImage;
import org.testcontainers.utility.DockerImageName;

import java.util.Arrays;
import java.util.stream.Stream;

import static org.assertj.core.api.Assertions.assertThat;

@RunWith(Enclosed.class)
public class LegacyModeTest {
class LegacyModeTest {

private static DockerImageName LOCALSTACK_CUSTOM_TAG = DockerImageName
private static final DockerImageName LOCALSTACK_CUSTOM_TAG = DockerImageName
.parse("localstack/localstack:0.12.8")
.withTag("custom");

@RunWith(Parameterized.class)
@AllArgsConstructor
public static class Off {

private final String description;

private final LocalStackContainer localstack;

@Parameterized.Parameters(name = "{0}")
public static Iterable<Object[]> constructors() {
return Arrays.asList(
new Object[][] {
{ "0.12", new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_12_IMAGE) },
{ "0.11", new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_11_IMAGE) },
{
"0.11 with legacy = off",
new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_11_IMAGE, false),
},
}
);
}

@Test
public void samePortIsExposedForAllServices() {
localstack.withServices(Service.S3, Service.SQS);
localstack.start();

try {
assertThat(localstack.getExposedPorts()).as("A single port is exposed").hasSize(1);
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint overrides are different")
.isEqualTo(localstack.getEndpointOverride(Service.S3).toString());
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint configuration have different endpoints")
.isEqualTo(localstack.getEndpointOverride(Service.S3).toString());
} finally {
localstack.stop();
}
}
@BeforeAll
static void setup() {
DockerClient dockerClient = DockerClientFactory.instance().client();
dockerClient
.tagImageCmd(
new RemoteDockerImage(LocalstackTestImages.LOCALSTACK_0_12_IMAGE).get(),
LOCALSTACK_CUSTOM_TAG.getRepository(),
LOCALSTACK_CUSTOM_TAG.getVersionPart()
)
.exec();
}

@RunWith(Parameterized.class)
@AllArgsConstructor
public static class On {

private final String description;

private final LocalStackContainer localstack;

@BeforeClass
public static void createCustomTag() {
DockerClient dockerClient = DockerClientFactory.instance().client();
dockerClient
.tagImageCmd(
new RemoteDockerImage(LocalstackTestImages.LOCALSTACK_0_12_IMAGE).get(),
LOCALSTACK_CUSTOM_TAG.getRepository(),
LOCALSTACK_CUSTOM_TAG.getVersionPart()
)
.exec();
}
static Stream<Arguments> localstackVersionWithLegacyOff() {
return Stream.of(
Arguments.arguments("0.12", new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_12_IMAGE)),
Arguments.arguments("0.11", new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_11_IMAGE)),
Arguments.arguments(
"0.11 with legacy = off",
new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_11_IMAGE, false)
)
);
}

@Parameterized.Parameters(name = "{0}")
public static Iterable<Object[]> constructors() {
return Arrays.asList(
new Object[][] {
{ "0.10", new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_10_IMAGE) },
{ "custom", new LocalStackContainer(LOCALSTACK_CUSTOM_TAG) },
{
"0.11 with legacy = on",
new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_11_IMAGE, true),
},
}
);
@ParameterizedTest(name = "{0}")
@MethodSource("localstackVersionWithLegacyOff")
void samePortIsExposedForAllServices(String description, LocalStackContainer localstack) {
localstack.withServices(Service.S3, Service.SQS);
localstack.start();

try {
assertThat(localstack.getExposedPorts()).as("A single port is exposed").hasSize(1);
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint overrides are different")
.isEqualTo(localstack.getEndpointOverride(Service.S3).toString());
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint configuration have different endpoints")
.isEqualTo(localstack.getEndpointOverride(Service.S3).toString());
} finally {
localstack.stop();
}
}

@Test
public void differentPortsAreExposed() {
localstack.withServices(Service.S3, Service.SQS);
localstack.start();
public static Stream<Arguments> localstackVersionWithLegacyOn() {
return Stream.of(
Arguments.arguments("0.10", new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_10_IMAGE)),
Arguments.arguments("custom", new LocalStackContainer(LOCALSTACK_CUSTOM_TAG)),
Arguments.arguments(
"0.11 with legacy = on",
new LocalStackContainer(LocalstackTestImages.LOCALSTACK_0_11_IMAGE, true)
)
);
}

try {
assertThat(localstack.getExposedPorts()).as("Multiple ports are exposed").hasSizeGreaterThan(1);
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint overrides are different")
.isNotEqualTo(localstack.getEndpointOverride(Service.S3).toString());
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint configuration have different endpoints")
.isNotEqualTo(localstack.getEndpointOverride(Service.S3).toString());
} finally {
localstack.stop();
}
@ParameterizedTest(name = "{0}")
@MethodSource("localstackVersionWithLegacyOn")
void differentPortsAreExposed(String description, LocalStackContainer localstack) {
localstack.withServices(Service.S3, Service.SQS);
localstack.start();

try {
assertThat(localstack.getExposedPorts()).as("Multiple ports are exposed").hasSizeGreaterThan(1);
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint overrides are different")
.isNotEqualTo(localstack.getEndpointOverride(Service.S3).toString());
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
.as("Endpoint configuration have different endpoints")
.isNotEqualTo(localstack.getEndpointOverride(Service.S3).toString());
} finally {
localstack.stop();
}
}

@RunWith(Parameterized.class)
@AllArgsConstructor
public static class LegacyModeUnitTest {

private final String version;

private final boolean shouldUseLegacyMode;

@Parameterized.Parameters(name = "{0} - {1}")
public static Iterable<Object[]> constructors() {
return Arrays.asList(
new Object[][] {
{ "latest", false },
{ "s3-latest", false },
{ "latest-bigdata", false },
{ "3.4.0-bigdata", false },
{ "3.4.0@sha256:54fcf172f6ff70909e1e26652c3bb4587282890aff0d02c20aa7695469476ac0", false },
{ "1.4@sha256:7badf31c550f81151c485980e17542592942d7f05acc09723c5f276d41b5927d", false },
{ "3.4.0", false },
{ "0.12", false },
{ "0.11", false },
{ "sha256:8bf0d744fea26603f2b11ef7206edb38375ef954258afaeda96532a6c9c1ab8b", false },
{ "0.10.7@sha256:45ef287e29af7285c6e4013fafea1e3567c167cd22d12282f0a5f9c7894b1c5f", true },
{ "0.10.7", true },
{ "0.9.6", true },
}
);
}
public static Stream<Arguments> constructors() {
return Stream.of(
Arguments.arguments("latest", false),
Arguments.arguments("s3-latest", false),
Arguments.arguments("latest-bigdata", false),
Arguments.arguments("3.4.0-bigdata", false),
Arguments.arguments("3.4.0@sha256:54fcf172f6ff70909e1e26652c3bb4587282890aff0d02c20aa7695469476ac0", false),
Arguments.arguments("1.4@sha256:7badf31c550f81151c485980e17542592942d7f05acc09723c5f276d41b5927d", false),
Arguments.arguments("3.4.0", false),
Arguments.arguments("0.12", false),
Arguments.arguments("0.11", false),
Arguments.arguments("sha256:8bf0d744fea26603f2b11ef7206edb38375ef954258afaeda96532a6c9c1ab8b", false),
Arguments.arguments("0.10.7@sha256:45ef287e29af7285c6e4013fafea1e3567c167cd22d12282f0a5f9c7894b1c5f", true),
Arguments.arguments("0.10.7", true),
Arguments.arguments("0.9.6", true)
);
}

@Test
public void samePortIsExposedForAllServices() {
assertThat(LocalStackContainer.shouldRunInLegacyMode(version)).isEqualTo(shouldUseLegacyMode);
}
@ParameterizedTest
@MethodSource("constructors")
void testLegacyMode(String version, boolean shouldUseLegacyMode) {
assertThat(LocalStackContainer.shouldRunInLegacyMode(version)).isEqualTo(shouldUseLegacyMode);
}
}
Loading
Loading