Skip to content

Move Milvus tests to JUnit Jupiter #10747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
+11 −4
Merged

Move Milvus tests to JUnit Jupiter #10747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/milvus/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ description = "Testcontainers :: Milvus"
dependencies {
api project(':testcontainers')

testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'

testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
testImplementation 'org.assertj:assertj-core:3.27.4'
testImplementation 'io.milvus:milvus-sdk-java:2.6.3'
}

test {
useJUnitPlatform()
}
8 changes: 4 additions & 4 deletions modules/milvus/src/test/java/org/testcontainers/milvus/MilvusContainerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@

import io.milvus.client.MilvusServiceClient;
import io.milvus.param.ConnectParam;
import org.junit.Test;
import org.junit.jupiter.api.Test;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.Network;
import org.testcontainers.containers.wait.strategy.Wait;

import static org.assertj.core.api.Assertions.assertThat;

public class MilvusContainerTest {
class MilvusContainerTest {

@Test
public void withDefaultConfig() {
void withDefaultConfig() {
try (
// milvusContainer {
MilvusContainer milvus = new MilvusContainer("milvusdb/milvus:v2.3.9")
Expand All @@ -26,7 +26,7 @@ public void withDefaultConfig() {
}

@Test
public void withExternalEtcd() {
void withExternalEtcd() {
try (
// externalEtcd {
Network network = Network.newNetwork();
Expand Down
Loading