Skip to content

Move Nginx tests to JUnit Jupiter #10752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 1 commit into from
Sep 4, 2025
+30 −22
Merged

Move Nginx tests to JUnit Jupiter #10752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/nginx/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ description = "Testcontainers :: Nginx"
dependencies {
api project(':testcontainers')
compileOnly 'org.jetbrains:annotations:26.0.2'

testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'

testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
testImplementation 'org.assertj:assertj-core:3.27.4'
}

Expand All @@ -11,3 +15,7 @@ tasks.japicmp {
"org.testcontainers.containers.NginxContainer"
]
}

test {
useJUnitPlatform()
}
44 changes: 22 additions & 22 deletions modules/nginx/src/test/java/org/testcontainers/junit/SimpleNginxTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
package org.testcontainers.junit;

import lombok.Cleanup;
import org.junit.BeforeClass;
import org.junit.Rule;
import org.junit.Test;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.testcontainers.containers.NginxContainer;
import org.testcontainers.containers.wait.strategy.HttpWaitStrategy;
import org.testcontainers.utility.DockerImageName;
Expand All @@ -20,23 +19,15 @@

import static org.assertj.core.api.Assertions.assertThat;

public class SimpleNginxTest {
class SimpleNginxTest {

private static final DockerImageName NGINX_IMAGE = DockerImageName.parse("nginx:1.27.0-alpine3.19-slim");

private static String tmpDirectory = System.getProperty("user.home") + "/.tmp-test-container";

// creatingContainer {
@Rule
public NginxContainer nginx = new NginxContainer(NGINX_IMAGE)
.withCopyFileToContainer(MountableFile.forHostPath(tmpDirectory), "/usr/share/nginx/html")
.waitingFor(new HttpWaitStrategy());

// }

@SuppressWarnings({ "Duplicates", "ResultOfMethodCallIgnored" })
@BeforeClass
public static void setupContent() throws Exception {
@BeforeAll
static void setupContent() throws Exception {
// addCustomContent {
// Create a temporary dir
File contentFolder = new File(tmpDirectory);
Expand All @@ -53,15 +44,24 @@ public static void setupContent() throws Exception {
}

@Test
public void testSimple() throws Exception {
// getFromNginxServer {
URL baseUrl = nginx.getBaseUrl("http", 80);
void testSimple() throws Exception {
try (
// creatingContainer {
NginxContainer nginx = new NginxContainer(NGINX_IMAGE)
.withCopyFileToContainer(MountableFile.forHostPath(tmpDirectory), "/usr/share/nginx/html")
.waitingFor(new HttpWaitStrategy());
// }
) {
nginx.start();
// getFromNginxServer {
URL baseUrl = nginx.getBaseUrl("http", 80);

assertThat(responseFromNginx(baseUrl))
.as("An HTTP GET from the Nginx server returns the index.html from the custom content directory")
.contains("Hello World!");
// }
assertHasCorrectExposedAndLivenessCheckPorts(nginx);
assertThat(responseFromNginx(baseUrl))
.as("An HTTP GET from the Nginx server returns the index.html from the custom content directory")
.contains("Hello World!");
// }
assertHasCorrectExposedAndLivenessCheckPorts(nginx);
}
}

private void assertHasCorrectExposedAndLivenessCheckPorts(NginxContainer nginxContainer) {
Expand Down
Loading