Fix Kafka listeners and advertised listeners config to come out of sync#11068
Merged
eddumelendez merged 1 commit intotestcontainers:mainfrom Oct 14, 2025
Merged
Fix Kafka listeners and advertised listeners config to come out of sync#11068eddumelendez merged 1 commit intotestcontainers:mainfrom
eddumelendez merged 1 commit intotestcontainers:mainfrom
Conversation
…teners to come out of sync
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KafkaContainerandConfluentKafkaContainerboth have a pair ofHashSetproperties:listenersandadvertisedListeners. At some point, these are being fed intoKafkaHelper.resolveListeners(GenericContainer<?>, Set<String>)andKafkaHelper.resolveAdvertisedListeners(Set<Supplier<String>>)to help generate values forKAFKA_LISTENERSandKAFKA_ADVERTISED_LISTENERS, respectively. Each registered listener will get assigned the protocolTC-<X>where<X>essentially is the index position of the listener in eachHashSet, but sinceHashSetdoesn't guarantee any such order, a listener might be registered asTC-0in theKAFKA_LISTENERSenv variable and asTC-1inKAFKA_ADVERTISED_LISTENERS.The least intrusive solution I could think of was to replace
HashSetwithLinkedHashSet, which does guarantee insertion order, and should therefore work better with the way theKafkaHelpermethods are designed.