Skip to content

fix: MS SQLServer container does not allow for custom queryString #9463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyleAure wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix: MS SQLServer container does not allow for custom queryString #9463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,20 @@ protected String constructUrlForConnection(String queryString) {
if (urlParameters.keySet().stream().map(String::toLowerCase).noneMatch("encrypt"::equals)) {
urlParameters.put("encrypt", "false");
}
return super.constructUrlForConnection(queryString);

// The JDBC driver of MS SQL Server does not use the traditional '?'
// as the starting character nor the '&' as the delimiter of additional parameters.
String baseUrl = getJdbcUrl();

if ("".equals(queryString)) {
return baseUrl;
}

if (!queryString.startsWith(";")) {
throw new IllegalArgumentException("The ';' character must be included");
}

return baseUrl + queryString;
}

@Override
Expand Down